Netdev List
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
	stephen@networkplumber.org, kuba@kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com,
	jiri@resnulli.us
Subject: Re: [PATCH iproute2-next v3 2/2] devlink: support u64-array values in devlink param show/set
Date: Wed, 1 Jul 2026 17:53:33 -0600	[thread overview]
Message-ID: <6c59d8f0-9a70-46d1-bf70-1e69c1869fb5@kernel.org> (raw)
In-Reply-To: <20260701031359.839221-3-rkannoth@marvell.com>

On 6/30/26 9:13 PM, Ratheesh Kannoth wrote:
> Add support for DEVLINK_VAR_ATTR_TYPE_U64_ARRAY parameters that carry
> multiple DEVLINK_ATTR_PARAM_VALUE_DATA attributes. Parse and display
> u64 array values in param show, and accept space- or comma-separated
> u64 values in devlink and port param set commands.
> 
>   - Show search order
> 
>   devlink dev param show pci/0002:01:00.0 name npc_srch_order
>   pci/0002:01:00.0:
>     name npc_srch_order type driver-specific
>       values:
>         cmode runtime value  value  0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31

"value value"? Is that correct or a typo in the commit message?

You are dumping it as a string which for json is wrong -- it should be
an array.


  reply	other threads:[~2026-07-01 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  3:13 [PATCH iproute2-next v3 0/2] devlink: support u64-array devlink parameters Ratheesh Kannoth
2026-07-01  3:13 ` [PATCH iproute2-next v3 1/2] devlink: use DEVLINK_VAR_ATTR_TYPE_* in param show/set Ratheesh Kannoth
2026-07-01  3:13 ` [PATCH iproute2-next v3 2/2] devlink: support u64-array values in devlink " Ratheesh Kannoth
2026-07-01 23:53   ` David Ahern [this message]
2026-07-02  2:51     ` Ratheesh Kannoth
2026-07-02  3:06     ` Ratheesh Kannoth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c59d8f0-9a70-46d1-bf70-1e69c1869fb5@kernel.org \
    --to=dsahern@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rkannoth@marvell.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox