From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Berger Subject: Re: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error Date: Mon, 4 Dec 2017 17:05:27 -0800 Message-ID: <6c661895-0587-26fb-cfd9-cf24dee2e002@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> <1512242782-7134-3-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Arvind Yadav , wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Return-path: In-Reply-To: <1512242782-7134-3-git-send-email-arvind.yadav.cs@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 12/02/2017 11:26 AM, Arvind Yadav wrote: > The change is to call free_netdev(), If of_match_node() will fail. > > Signed-off-by: Arvind Yadav > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index e2f1268..e0a8f79 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -3363,8 +3363,10 @@ static int bcmgenet_probe(struct platform_device *pdev) > > if (dn) { > of_id = of_match_node(bcmgenet_match, dn); > - if (!of_id) > - return -EINVAL; > + if (!of_id) { > + err = -EINVAL; > + goto err; > + } > } > > priv = netdev_priv(dev); > I agree with the fix if you want to resubmit separate from this series and please include a "fixes" tag. Thanks, Doug