From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F50C4360F for ; Tue, 2 Apr 2019 17:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A1C32084B for ; Tue, 2 Apr 2019 17:39:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="frev/aoV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731674AbfDBRjl (ORCPT ); Tue, 2 Apr 2019 13:39:41 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37273 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730392AbfDBRjl (ORCPT ); Tue, 2 Apr 2019 13:39:41 -0400 Received: by mail-wm1-f67.google.com with SMTP id v14so4807825wmf.2 for ; Tue, 02 Apr 2019 10:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5AcD5zvsKJqhliI/uHduDEEkwxKnsjpF/Z/ywISbpxY=; b=frev/aoVH+vpej+r5WCySx6tDKHvKXXSiw/6ozoKCw/lQFxN0eV/H0SuBZuqdc7Qp0 nSgmDCP2A7u1pOy3Ztv/i8lm/LWjjYejQhKta8JfqLA9A9R8+IGxvo8lZ9xigM1TKJHt 9B0NXCLomVrVdCiXLFsy9kkJIYm11iRXdzgMzg89joIRNTtapZmDG8VVrUOCch3HUAES vIO81y6FmdWsKBwwU5iz0sZP+5FpXzBb0Gq6f8OugXFnueVUiDy63Kgmz/hiR1EobFS9 qWszhIJ199C/pbZ4E1vz4fPl+mGqvv7xvByasHKXAyN1y2snhrz/EZn8tPXkZk4kCmR8 A8qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5AcD5zvsKJqhliI/uHduDEEkwxKnsjpF/Z/ywISbpxY=; b=PRpOnOkOEmvEek1QEwwANOp4dUsqeUFzscIlui4z66SxcdlnSoCDR+1+SxDBjPeT8Y CjWIBcEdWpJYIYcrCcAH9oVr70Bye+O5iYvtjYnl2wljAo2XADxXCFom499NKldHq6sr dan3P+jfQQSiSOzTMZUQlIeUAuJQu4qxLI0gZAqt471KM+VW0mQwMX8bLgHgrlHL4HgR Vqu/L4KoByn3+RvP4aVghLiYJnrslIZAqR0QvOth0WOmBikBcuv4nAUQiH9yAkPwuAOw ymAhrlyXiSkAvTd/Ruql8/UmWdsvCfoDOktPq/Dp3RA871GQMzMLHfXao8Qe6wA6N1IR iRtQ== X-Gm-Message-State: APjAAAXsdnPl3Wv/k7md+GXvZ599D2lCrNgak/5Uv36N8yGVrmEuT9h9 ZTFJiHgNm0qkQY1cO2WKAQ6RAEsl X-Google-Smtp-Source: APXvYqw7U0DTPYsDaFoZhJIEh/GbV98tlv5gH2fR1mJo9II6HBJSvberRb2pTtMFVc5tTITnI+E0fg== X-Received: by 2002:a05:600c:2208:: with SMTP id z8mr4430853wml.89.1554226779544; Tue, 02 Apr 2019 10:39:39 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:e07d:a1a:1bc0:370? (p200300EA8BE1DD00E07D0A1A1BC00370.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:e07d:a1a:1bc0:370]) by smtp.googlemail.com with ESMTPSA id v14sm14305821wrr.20.2019.04.02.10.39.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 10:39:38 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status From: Heiner Kallweit To: Andrew Lunn Cc: "netdev@vger.kernel.org" References: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com> <20190331145813.GD20636@lunn.ch> Message-ID: <6c6effbc-366a-3082-a857-115ba94d069f@gmail.com> Date: Tue, 2 Apr 2019 19:39:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 31.03.2019 17:05, Heiner Kallweit wrote: > On 31.03.2019 16:58, Andrew Lunn wrote: >>> - In auto-neg case, skip populating lp_advertising if we >>> don't have a link. This avoids quite some unnecessary >>> MDIO reads in case of phylib polling mode. >> >> Hi Heiner >> >> Could it be that we don't have a link because what the partner is >> advertising does not intersect with what we are advertising? >> > Interesting point. Yes, I think I missed that scenario. > Just saw that Dave applied this patch. So I will send a fix to deal with this scenario properly. >> Hence knowing what it is adverting is actually useful in this case? >> >> Andrew >> > Heiner >