From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Lunn <andrew@lunn.ch>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/6] netdev_features: remove unused __UNUSED_NETIF_F_1
Date: Fri, 23 Aug 2024 14:34:13 +0200 [thread overview]
Message-ID: <6c72dbc6-98a1-4682-97ca-e2f76c81a178@intel.com> (raw)
In-Reply-To: <20240822163129.0982128f@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 22 Aug 2024 16:31:29 -0700
> On Thu, 22 Aug 2024 18:19:24 +0200 Alexander Lobakin wrote:
>>> I was simply suggesting to correct the changelog, and make clear we
>>> need a recent enough ethtool.
>>
>> Yeah I got it, thanks. Will reword.
>>
>>> We can not simply say that ethtool always supported the modern way
>>> (ETH_SS_FEATURES)
>>
>> I didn't work with Linux at all back in 2011, so I didn't even know
>> there were older ways of handling this :D Always something to learn, nice.
>
> Are we removing the bit definitions just for code cleanliness?
Uhm, no, to free more bits to be able to add new features.
> On one hand it may be good to make any potential breakage obvious,
> on the other we could avoid regressions if we stick to reserving
> the bits, and reusing them, but the bits we don't delete could remain
> at their current position?
Hmm, sounds fine. IOW just rename all the bits I remove to
__UNUSED_NETIF_F_xx?
Thanks,
Olek
next prev parent reply other threads:[~2024-08-23 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 15:06 [PATCH net-next v4 0/6] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-08-21 15:06 ` [PATCH net-next v4 1/6] netdevice: convert private flags > BIT(31) to bitfields Alexander Lobakin
2024-08-21 15:06 ` [PATCH net-next v4 2/6] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-08-21 15:43 ` Eric Dumazet
2024-08-22 15:24 ` Alexander Lobakin
2024-08-22 16:12 ` Eric Dumazet
2024-08-22 16:19 ` Alexander Lobakin
2024-08-22 23:31 ` Jakub Kicinski
2024-08-23 12:34 ` Alexander Lobakin [this message]
2024-08-24 17:43 ` Jakub Kicinski
2024-08-25 8:19 ` Gal Pressman
2024-08-26 15:09 ` Jakub Kicinski
2024-08-26 15:38 ` Gal Pressman
2024-08-21 15:06 ` [PATCH net-next v4 3/6] netdev_features: convert NETIF_F_LLTX to dev->lltx Alexander Lobakin
2024-08-21 15:06 ` [PATCH net-next v4 4/6] netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local Alexander Lobakin
2024-08-21 15:06 ` [PATCH net-next v4 5/6] netdev_features: convert NETIF_F_FCOE_MTU to dev->fcoe_mtu Alexander Lobakin
2024-08-21 15:07 ` [PATCH net-next v4 6/6] netdev_features: remove NETIF_F_ALL_FCOE Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c72dbc6-98a1-4682-97ca-e2f76c81a178@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).