Re: MT7530 bug, forward broadcast and unknown frames to the correct CPU port

Vladimir Oltean
2023-05-17T15:52:57Z

On Tue, May 16, 2023 at 11:01:02PM +0300, Arınç ÜNAL wrote:
> Without preferring port 6:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-20.00 sec 374 MBytes 157 Mbits/sec 734 sender
> [ 5][TX-C] 0.00-20.00 sec 373 MBytes 156 Mbits/sec receiver
> [ 7][RX-C] 0.00-20.00 sec 1.81 GBytes 778 Mbits/sec 0 sender
> [ 7][RX-C] 0.00-20.00 sec 1.81 GBytes 777 Mbits/sec receiver
>
> With preferring port 6:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-20.00 sec 1.99 GBytes 856 Mbits/sec 273 sender
> [ 5][TX-C] 0.00-20.00 sec 1.99 GBytes 855 Mbits/sec receiver
> [ 7][RX-C] 0.00-20.00 sec 1.72 GBytes 737 Mbits/sec 15 sender
> [ 7][RX-C] 0.00-20.00 sec 1.71 GBytes 736 Mbits/sec receiver
>
> This scenario is quite popular as you would see a lot of people using one
> port for WAN and the other ports for LAN.
>
> Therefore, the "prefer local CPU port" operation would be useful. If you can
> introduce the operation to the DSA subsystem, I will make a patch to start
> using it on the MT7530 DSA subdriver.

Patches adding infrastructure will not be accepted without one user of
that infra, so if you could pick up my patch from the ML, keep my author
and signed-off-by tag, add yours afterwards, give it a compelling commit
message backed up by data such as this, and submit it along your mt7530
user, that would probably be good.