From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.125 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794996694; b=I0QzYWaWP4kjJvgYfkgK9qYkkfkBmAlBpzZhNks7p8QtXGPbLFjlywTlVJwIpU7PQrOp 3X6BErBFQigXLZ7io5q9N3nEF0c4sUVoJXi9NR/dcN3gUIxSSItFYAHK1B1McUvqhUlHN wraDCqGqOnyoNRZdrr16F7ZybKteWOTUcFyycJOzb2KXQYN/ogJ/GDCtIdvN3TmztxDPG m+mzADkxCmD90J3P58I6esngA4vgUhicjVtp9/jZynTUpToMlX/tnuG/fTDl5uqbRAYIi JRRMXKv6bc4OppuwlODIAq4du0Wrxf3MR2FfqbO5TZEvZf4zxTfgokpjaiwEsGqmfKQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794996694; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=D1MUY1H0VH1qHinNrqNAjg4w0W1AM6O//IjCUC504uI=; b=SfMwNuOsj8DJL5pBGVBey10amJl2SnkxhVBt/vVMaHHKk/ykiRed2duei9V0LJCrbTJA YI0L/khlJWry2lNtPt861f8T5VoXaxMnh4j2ZHOmM49+tht/8sC+R/qfM98ymJfsjBwlK dmZvzcBSCp+9rGZLZYSmSFDj7GK0+5rEJxZlI5BDFVCTdausfj+J6NnCpP2d2+xHsIFjB k7Ae+tISTF5lPiKb/7YSHarufq5D4KeFpggEXfHGdmLiVzHV7mQ9HIaDueU1qCQsxomzR z8krG0J1bconatWRLESsdavKqQAjg+FnP7hKvwWIYLp4fcqd/X73mH71lvB8r+gR5Qg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=OW5EI13u; arc=none smtp.remote-ip=91.218.175.125 Received: from mta0.migadu.com (out-125.mta0.migadu.com [91.218.175.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 059FE606A320 for ; Wed, 18 Nov 2026 10:11:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 059FE606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=OW5EI13u X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=+bB9g6Bv+semol6SWgegbWp0lH/3VoQYPrulmmDo324=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794996692; v=1; x=1795601492; b=OW5EI13uRMfGhs6ixdrLLuvaMP7KYvOoEEPvlEROAbKL1hYGSDT2CH4udseFxC7OBPwu+guP WNikBVVefcDsLc2OrtBc6DErGrO5w78T33QBmgpjThOx/ayqYPMVkdUo/13JRDD6T31YSBw7TBR J5GzMsPAe/k2v2ehEk0LYZlI= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id d58a89dcce9aff1c; Wed, 18 Nov 2026 10:11:32 +0000 X-Mizu-Trace-ID: d58a89dcce9aff1c X-Migadu-Flow: FLOW_OUT Message-ID: <6c94d413-02b8-4a1d-8a5f-9503a9ff4815@linux.dev> Date: Wed, 18 Nov 2026 19:11:26 +0900 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH nf v2 1/2] netfilter: nf_tables: only disable tables on a dormant transition To: Ma Xinmeng <1564938642@qq.com> Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Phil Sutter , Pablo Neira Ayuso , Florian Westphal References: <20261117161520.1031-1-1564938642@qq.com> From: Xuanqiang Luo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/11/18 at 1:14 Ma Xinmeng wrote: > nf_tables_commit() calls nf_tables_table_disable() for every NEWTABLE > transaction that has NFT_TABLE_F_DORMANT set and __NFT_TABLE_F_UPDATE. > Since table adoption introduced __NFT_TABLE_F_WAS_ORPHAN, UPDATE no > longer implies a dormant state change: re-owning an already dormant > PERSIST orphan sets UPDATE because of the adoption, even though the > table never left the dormant state. The commit then clears DORMANT, > walks the basechains, and unregisters a hook that was never registered, > which triggers WARN_ONCE("hook not found") in > __nf_unregister_net_hook(). > > Use __NFT_TABLE_F_WAS_AWAKEN, which records an awake-to-dormant > transition, instead of the current DORMANT flag. This skips the disable > for an already dormant adopted table while preserving the genuine > awake-to-dormant path. > > Fixes: 31bf508be656 ("netfilter: nf_tables: Implement table adoption support") > Signed-off-by: Ma Xinmeng <1564938642@qq.com> The patch looks good to me. Reviewed-by: Xuanqiang Luo Thanks, Xuanqiang