From: Edward Cree <ecree.xilinx@gmail.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
edward.cree@amd.com
Cc: linux-net-drivers@amd.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org,
habetsm.xilinx@gmail.com
Subject: Re: [PATCH net-next 4/5] sfc: add code to register and unregister encap matches
Date: Wed, 15 Mar 2023 14:01:23 +0000 [thread overview]
Message-ID: <6c9ca856-1749-9884-9852-6c19a15d2f68@gmail.com> (raw)
In-Reply-To: <ZBGTL9i9/rC6xSdQ@localhost.localdomain>
On 15/03/2023 09:43, Michal Swiatkowski wrote:
> On Tue, Mar 14, 2023 at 05:35:24PM +0000, edward.cree@amd.com wrote:
>> +static int efx_tc_flower_record_encap_match(struct efx_nic *efx,
>> + struct efx_tc_match *match,
>> + enum efx_encap_type type,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct efx_tc_encap_match *encap, *old;
>> + unsigned char ipv;
> int? or even boolean is_ipv4
...
>> + default: /* can't happen */
>> + NL_SET_ERR_MSG_FMT_MOD(extack, "Egress encap match on bad IP version %d",
>> + ipv);
>> + rc = -EOPNOTSUPP;
>> + goto fail_allocated;
> I will rewrite it to if. You will get rid of this unreachable code.
Yeah, that's probably better. Will do.
next prev parent reply other threads:[~2023-03-15 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 17:35 [PATCH net-next 0/5] sfc: support TC decap rules edward.cree
2023-03-14 17:35 ` [PATCH net-next 1/5] sfc: add notion of match on enc keys to MAE machinery edward.cree
2023-03-15 6:19 ` Michal Swiatkowski
2023-03-15 13:45 ` Edward Cree
2023-03-14 17:35 ` [PATCH net-next 2/5] sfc: handle enc keys in efx_tc_flower_parse_match() edward.cree
2023-03-15 9:01 ` Michal Swiatkowski
2023-03-15 13:48 ` Edward Cree
2023-03-14 17:35 ` [PATCH net-next 3/5] sfc: add functions to insert encap matches into the MAE edward.cree
2023-03-15 9:23 ` Michal Swiatkowski
2023-03-15 13:58 ` Edward Cree
2023-03-14 17:35 ` [PATCH net-next 4/5] sfc: add code to register and unregister encap matches edward.cree
2023-03-15 9:43 ` Michal Swiatkowski
2023-03-15 14:01 ` Edward Cree [this message]
2023-03-14 17:35 ` [PATCH net-next 5/5] sfc: add offloading of 'foreign' TC (decap) rules edward.cree
2023-03-14 20:29 ` kernel test robot
2023-03-15 10:11 ` Michal Swiatkowski
2023-03-15 14:43 ` Edward Cree
2023-03-22 22:35 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9ca856-1749-9884-9852-6c19a15d2f68@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).