From: "Li,Rongqing" <lirongqing@baidu.com>
To: "dust.li@linux.alibaba.com" <dust.li@linux.alibaba.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path when possible
Date: Fri, 3 Nov 2023 04:43:40 +0000 [thread overview]
Message-ID: <6cadd420741145b897cc18237ce78688@baidu.com> (raw)
In-Reply-To: <20231102145418.GH92403@linux.alibaba.com>
> -----Original Message-----
> From: Dust Li <dust.li@linux.alibaba.com>
> Sent: Thursday, November 2, 2023 10:54 PM
> To: Li,Rongqing <lirongqing@baidu.com>; linux-s390@vger.kernel.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path
> when possible
>
> On Thu, Nov 02, 2023 at 05:27:12PM +0800, Li RongQing wrote:
> >these is less opportunity that conn->tx_pushing is not 1, since
>
> these -> there ?
Yes, thanks
>
> >tx_pushing is just checked with 1, so move the setting tx_pushing to 1
> >after atomic_dec_and_test() return false, to avoid atomic_set and
> >smp_wmb in tx path when possible
>
> The patch should add [PATCH net-next] subject-prefix since this is an
> optimization.
>
OK
> Besides, do you have any performance number ?
Just try a simple performance test, seems same.
-Li
next prev parent reply other threads:[~2023-11-03 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 9:27 [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path when possible Li RongQing
2023-11-02 14:54 ` Dust Li
2023-11-03 4:43 ` Li,Rongqing [this message]
2023-11-02 20:42 ` Wenjia Zhang
2023-11-03 4:56 ` Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cadd420741145b897cc18237ce78688@baidu.com \
--to=lirongqing@baidu.com \
--cc=dust.li@linux.alibaba.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).