From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07709C282CE for ; Fri, 5 Apr 2019 21:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC43D20651 for ; Fri, 5 Apr 2019 21:11:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XbDTx29+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbfDEVL6 (ORCPT ); Fri, 5 Apr 2019 17:11:58 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44649 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfDEVL6 (ORCPT ); Fri, 5 Apr 2019 17:11:58 -0400 Received: by mail-pf1-f196.google.com with SMTP id y13so3917494pfm.11 for ; Fri, 05 Apr 2019 14:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zRH2x+Ntt6VPP0Jj0hPK95hwKnXd2F6Ay2HGkDVkAHo=; b=XbDTx29+o8KsD9cnCxsn7Vh/I73P7RHG4K+jwDY/3e47PdYoGE5oAamkb8AGtGq76M CVaH2GiQI1i3mPZwuA6H5lZAlhku4SVin62cjdE5p5eWmiE3x+INWLyfl9qv7uWN01ul Zb8iHEuMkvxcvnlfuGJ4QwN7+YaWlsUNH6mVxjM8pKV4gUwYRF4ZqNEwBtt/0G/Z384t PIpxMW8aY78aEowkdZ4kIAw49bR7J02uupwpDn8AkUDCCMN9iQauX38YmxGx1+YEbE/C QqfUYd3AB7G9M/G6QKvJJ5cuLgz4HuPAls/Obd/8FN4gWlMWD+MaOh7pxCYCgx98oIwv HHiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zRH2x+Ntt6VPP0Jj0hPK95hwKnXd2F6Ay2HGkDVkAHo=; b=EhndOAfP2MKK3JzC9N/Du/5JoOr4fupbM9/bQ0zV1rUXTR/bJtTRCAiP4jtkrJ1BbG UlNgQsHdg7onDjIX8t+QzZffjXnT0v/VZfinkXsb8Ob7txIUTe1txeAkrCoILC5nwdLZ KCFmEklEvC8WRBjmTcCHekg4SqZzMIrR/rFqb5Ens7SdjzaDmzL6R0MFu2Orfe5XUUfo 1za1pkofAhB+7bZw5c4A72+UB8T1PQTs3zai0HJX5OIjO7gItn9llcC+oWQwtjaQIwMA tMMYgk6GcV0ekppwRZ7GVAEAEuhzzYeI0N3DynQ4oO//UV5LdNfuGTCNagH2oC2ipMRx X8fA== X-Gm-Message-State: APjAAAVpkQ2aWh44aI9NyGw0W5ScvBBMnhwMd+o2ZIPjzXB3Cn68Pq6R Du/cPF64cOPa85youBMgRsqmAKL5 X-Google-Smtp-Source: APXvYqwxFFgogJFrMW71OjDWLGkrV9vTCCYUszo6DNviRwQAHvL/KZjJM5Ti8LCSVf9Q1pmYRIlXYQ== X-Received: by 2002:a63:bd42:: with SMTP id d2mr14342790pgp.319.1554498715896; Fri, 05 Apr 2019 14:11:55 -0700 (PDT) Received: from [10.67.50.16] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id k65sm38570248pfb.68.2019.04.05.14.11.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 14:11:54 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve link partner capability detection To: Heiner Kallweit , Andrew Lunn Cc: David Miller , "netdev@vger.kernel.org" References: <20190405194821.GI23536@lunn.ch> <6a86f31f-dda8-77d9-aace-9ad1ad770a28@gmail.com> <20190405202729.GK23536@lunn.ch> <20190405204319.GM23536@lunn.ch> <7e6fc94d-5da9-b87d-a0d3-3e2ee5ff5961@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <6cc85416-5ccd-ec90-ede5-11d9cfa298b3@gmail.com> Date: Fri, 5 Apr 2019 14:11:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <7e6fc94d-5da9-b87d-a0d3-3e2ee5ff5961@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/19 1:51 PM, Heiner Kallweit wrote: > On 05.04.2019 22:43, Andrew Lunn wrote: >>> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this >>> case didn't change. >>> >>>> A Fast MAC connected to a Giga PHY. The MAC driver will of used >>>> phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000 >>>> does exist and we should report what the peer is advertising. >>>> >>> That's what we're doing now with this patch. >> >> Hi Heiner >> >> What i don't get is why we need to do anything based on the MAC. All >> we need to do is look at BMSR_ESTATEN, and from that decided if we >> should look at MII_STAT1000 or not. When reporting what the peer can >> do, we should not care what the local MAC can do. >> > Do we have a misunderstanding? What you describe is exactly what we're > doing now. BMSR_ESTATEN is read by genphy_read_abilities(). > I just don't want to read BMSR whenever genphy_read_status() is called. You have to read the BMSR to determine the link status anyway, did you mean: have to check BMSR_ESTATEN whenever genphy_read_status() is called? -- Florian