From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Kumar, M Chetan" <m.chetan.kumar@linux.intel.com>
Cc: Netdev <netdev@vger.kernel.org>,
kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
krishna.c.sudi@intel.com, linuxwwan@intel.com,
Devegowda Chandrashekar <chandrashekar.devegowda@intel.com>,
Mishra Soumya Prakash <soumya.prakash.mishra@intel.com>
Subject: Re: [PATCH net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection
Date: Tue, 6 Sep 2022 13:31:43 +0300 (EEST) [thread overview]
Message-ID: <6cceb17f-8010-209a-a845-3fe9bcd332ab@linux.intel.com> (raw)
In-Reply-To: <15e9b3bd-5d3d-7b44-758f-4013b61e51fa@linux.intel.com>
On Tue, 6 Sep 2022, Kumar, M Chetan wrote:
> Thank you Ilpo for reviewing patches.
> Will address patch4 & patch5 review comments in v2.
A small correction & one additional item below.
> > > + read_len = count > skb->len ? skb->len : count;
> >
> > max_t()
I should have said min_t(), obviously.
> > > + actual_count = count > txq_mtu ? txq_mtu : count;
> >
> > max_t()
Here too, min_t().
> > > + if (read_bytes < 0) {
> > > + dev_err(port->dev, "status read failed");
> >
> > Printing "read failed" for -ERESTARTSYS/-EINTR??
Missing \n. There are also other similar dev_err()s, please check them
through (and perhaps others too besides dev_err()).
--
i.
next prev parent reply other threads:[~2022-09-06 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 4:24 [PATCH net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection m.chetan.kumar
2022-08-18 14:33 ` Ilpo Järvinen
2022-09-06 10:15 ` Kumar, M Chetan
2022-09-06 10:31 ` Ilpo Järvinen [this message]
2022-08-30 2:21 ` Sergey Ryazanov
2022-09-03 8:31 ` Kumar, M Chetan
2022-09-06 23:24 ` Sergey Ryazanov
2022-09-07 15:23 ` Loic Poulain
2022-09-08 15:08 ` Kumar, M Chetan
2022-09-08 15:48 ` Kumar, M Chetan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cceb17f-8010-209a-a845-3fe9bcd332ab@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=krishna.c.sudi@intel.com \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=soumya.prakash.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).