From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Subject: Re: [PATCH v5 net-next 2/3] rds: Enable RDS IPv6 support Date: Mon, 23 Jul 2018 21:16:10 -0700 Message-ID: <6ce5dd71-6854-8e9d-b242-be7eb5703fb3@oracle.com> References: <5ed088681a8508278fd3f5a7ec8eee0179034f12.1532404047.git.ka-cheong.poon@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, rds-devel@oss.oracle.com, sowmini.varadhan@oracle.com To: Ka-Cheong Poon , netdev@vger.kernel.org Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:42168 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388090AbeGXFUm (ORCPT ); Tue, 24 Jul 2018 01:20:42 -0400 In-Reply-To: <5ed088681a8508278fd3f5a7ec8eee0179034f12.1532404047.git.ka-cheong.poon@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/23/18 8:51 PM, Ka-Cheong Poon wrote: > This patch enables RDS to use IPv6 addresses. For RDS/TCP, the > listener is now an IPv6 endpoint which accepts both IPv4 and IPv6 > connection requests. RDS/RDMA/IB uses a private data (struct > rds_ib_connect_private) exchange between endpoints at RDS connection > establishment time to support RDMA. This private data exchange uses a > 32 bit integer to represent an IP address. This needs to be changed in > order to support IPv6. A new private data struct > rds6_ib_connect_private is introduced to handle this. To ensure > backward compatibility, an IPv6 capable RDS stack uses another RDMA > listener port (RDS_CM_PORT) to accept IPv6 connection. And it > continues to use the original RDS_PORT for IPv4 RDS connections. When > it needs to communicate with an IPv6 peer, it uses the RDS_CM_PORT to > send the connection set up request. > > v5: Fixed syntax problem (David Miller). > > v4: Changed port history comments in rds.h (Sowmini Varadhan). > > v3: Added support to set up IPv4 connection using mapped address > (David Miller). > Added support to set up connection between link local and non-link > addresses. > Various review comments from Santosh Shilimkar and Sowmini Varadhan. > > v2: Fixed bound and peer address scope mismatched issue. > Added back rds_connect() IPv6 changes. > > Signed-off-by: Ka-Cheong Poon > --- Acked-by: Santosh Shilimkar