From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530 Date: Fri, 30 Nov 2018 09:41:47 -0800 Message-ID: <6d031e8f-17cd-cf64-9d05-a5b48bf448a7@gmail.com> References: <20181130075737.8041-1-gerg@kernel.org> <20181130075737.8041-4-gerg@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: blogic@openwrt.org, neil@brown.name To: gerg@kernel.org, sean.wang@mediatek.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org Return-path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:43412 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbeLAEv5 (ORCPT ); Fri, 30 Nov 2018 23:51:57 -0500 Received: by mail-pf1-f194.google.com with SMTP id w73so3145944pfk.10 for ; Fri, 30 Nov 2018 09:41:55 -0800 (PST) In-Reply-To: <20181130075737.8041-4-gerg@kernel.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Greg, On 11/29/2018 11:57 PM, gerg@kernel.org wrote: > From: Greg Ungerer > > Add descriptive entries for the new bindings introduced to support the > MT7530 implementation in the MediaTek MT7621 SoC. > > New bindings added for: > > mediatek,no-clock-regulator > mediatek,mfc-has-cpuport I don't think any of these properties are necessary, if you can either use a compatible string, and/or infer the actual model at runtime in the driver's probe function, then you can assess based on that chip model as well as the properties being provided in Device Tree whether these resources must be grabbed and used. See mv88e6xxx and b53 for how these drivers deal with supporting several distinct models within the same code base. As far as the MFC programming goes, this is definitively something that must be done once you know the chip model you are dealing with. -- Florian