From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH RFC v2 net-next 03/25] netlink: introduce NLM_F_DUMP_PROPER_HDR flag Date: Tue, 2 Oct 2018 08:57:24 -0600 Message-ID: <6d1380b4-217c-387b-7e44-efaa8d091108@gmail.com> References: <20181002002851.5002-1-dsahern@kernel.org> <20181002002851.5002-4-dsahern@kernel.org> <20181002130614.77856ff8@redhat.com> <20181002111831.j6ov4bqhy3zi3vj6@brauner.io> <20181002132755.267a11fe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Ahern , netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org To: Jiri Benc , Christian Brauner Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:39469 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbeJBVlP (ORCPT ); Tue, 2 Oct 2018 17:41:15 -0400 Received: by mail-pl1-f193.google.com with SMTP id w14-v6so1819899plp.6 for ; Tue, 02 Oct 2018 07:57:27 -0700 (PDT) In-Reply-To: <20181002132755.267a11fe@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/2/18 5:27 AM, Jiri Benc wrote: > On Tue, 2 Oct 2018 13:18:32 +0200, Christian Brauner wrote: >> I didn't find this in the linked thread. > > Maybe it was suggested in another thread or in person on a conference, > I can't remember, it's too long ago, sorry. > >> What I find interesting and convincing is one of Dave's points: >> >> "I'm beginning to wonder if we can just change this unilaterally to >> not ignore unrecognized attributes. >> >> I am increasingly certain that things that would "break" we wouldn't >> want to succeed anyways." [1] > > It's unfortunate we can't do that. I'd like it. You can when you introduce a new option or a new flag that is required to get new behavior like kernel side filtering. > >> But a socket option or this header flag both sound acceptable to me. Was >> there any more detail on how a socket option would look like, i.e. an >> api proposal or something? > > Look at how NETLINK_CAP_ACK and NETLINK_EXT_ACK is implemented. I chose a netlink flag for consistency with NLM_F_DUMP_INTR and NLM_F_DUMP_FILTERED. Both are netlink flags. This patch set fixes only what is broken -- dumps.