From: David Ahern <dsa@cumulusnetworks.com>
To: 张胜举 <zhangshengju@cmss.chinamobile.com>, netdev@vger.kernel.org
Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump
Date: Sun, 27 Nov 2016 19:39:18 -0700 [thread overview]
Message-ID: <6d1a324e-e29e-e2dd-a6fc-1e9b4455cb3d@cumulusnetworks.com> (raw)
In-Reply-To: <001c01d2491f$fcd53250$f67f96f0$@cmss.chinamobile.com>
On 11/27/16 7:34 PM, 张胜举 wrote:
>> -----Original Message-----
>> From: David Ahern [mailto:dsa@cumulusnetworks.com]
>> Sent: Monday, November 28, 2016 10:10 AM
>> To: Zhang Shengju <zhangshengju@cmss.chinamobile.com>;
>> netdev@vger.kernel.org
>> Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump
>>
>> On 11/27/16 6:32 PM, Zhang Shengju wrote:
>>> Loop index in neigh dump function is not updated correctly under some
>>> circumstances, this patch will fix it.
>>
>> What's an example?
>
> If dev is filtered out, the original code goes to next loop without updating
> loop index 'idx'.
And you have a use case with missing or redundant data? Or is your comment based on a review of code only?
>> You are completely rewriting the dump loops.
>
> I put 'idx++' into for loop, so I replace 'goto' with 'continue'. The
> other change is style related.
A "fixes" should not include 'style related' changes.
next prev parent reply other threads:[~2016-11-28 2:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 1:32 [net,v2] neigh: fix the loop index error in neigh dump Zhang Shengju
2016-11-28 2:09 ` David Ahern
2016-11-28 2:34 ` 张胜举
2016-11-28 2:39 ` David Ahern [this message]
2016-11-28 2:53 ` 张胜举
2016-11-28 2:56 ` David Ahern
2016-11-28 3:09 ` David Ahern
2016-11-28 4:50 ` 张胜举
2016-11-28 5:07 ` David Ahern
2016-11-28 6:28 ` 张胜举
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1a324e-e29e-e2dd-a6fc-1e9b4455cb3d@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox