From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E694E328DB for ; Fri, 4 Oct 2024 04:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728017111; cv=none; b=CWKrgdTYEDbzE5824ldJun2xLVkULKHfXKuI6Kw+Z9CO0bXJOL53oE35mutt6b8EuHL5l6tz461YlDQa7zORx+DVE5yBCXiBWbB5SewE3gdglnzhPmDRwuMyc1AAzwIgoSlkyQOEt+3z9UItWvsNcN8Tz/dO4j0t6uBZ4lcoNKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728017111; c=relaxed/simple; bh=VmwvU0W4CbtoHjdtRtYbUa1zfcrUwdOCsDV5l+mX1gQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=MqvurnnD2XGkMk8kVu1LFt1ZDjgvjLqYHxMdg3zOwgWW4tFtJJ5Jwq8aoZ83e5yOv19ryz9rb99l5+ZpOnk7xmJ/SaVHdgxkwRvyRzEv9j91rrsqS/3nWbXMiUUQifEYlQAlS4GKrCawlhFTI1NVk/JR67VYyunt6e+gBPsf9hQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cif02BMw; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cif02BMw" Message-ID: <6d23b607-b6d6-4074-8778-c50bf3bd0b91@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728017103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ytssWJLKmXIWXSrDg9ABlNpbkQhbsJOWwycT6PoQRhQ=; b=cif02BMw0GzdjzhEZDwFVDFEIppcN7DFA9RB7RJTWvYL/k1JyQxwrtdZ3o/ht160Nnev2+ MjCoa0xOwItozXfUK1vw63f/lurOBt0ZK2wv8UaJ7r97F1YtJeztgwwIFJKN+I4FgTXwUS D5qe/rCsFpIY8ITEVkZkD1Gqg0UU6Go= Date: Thu, 3 Oct 2024 21:44:52 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau To: =?UTF-8?Q?Alexis_Lothor=C3=A9?= Cc: Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , Lorenzo Bianconi , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , "David S. Miller" , Jesper Dangaard Brouer , Maxime Chevallier , ebpf@linuxfoundation.org, Thomas Petazzoni , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org References: <20240910-convert_xdp_tests-v2-1-a46367c9d038@bootlin.com> <64df8d41-6cfb-45a9-8337-5cc04daedb60@linux.dev> <20240914063828.7bd73c5e@kernel.org> <464e0ae0-d6e3-4da4-a157-f74260f96275@bootlin.com> <366e4392-bd00-4120-8585-a71b3952e365@linux.dev> Content-Language: en-US In-Reply-To: <366e4392-bd00-4120-8585-a71b3952e365@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/24/24 6:37 PM, Martin KaFai Lau wrote: > There are other .sh tests that could better use the test_progs migration. In > particular the ones without existing test coverage. For non XDP related, > test_tcp_check_syncookie.sh, test_flow_dissector.sh, and test_tc_edt.sh should > be the good ones. I just took a closer look at the test_tc_edt.* for another reason. It seems doing some bandwidth test which may not be a good fit (e.g. too flaky) for test_progs. I would leave it to the bottom of the todo list for now. > > For XDP, test_xdp_meta.sh should be useful also. You may also want to check the > test_xdp_redirect_*.sh. > >> processes and tcp/udp channels involved), but if keeping the standalone version >> is really needed, I can give a try. Does it sound reasonable ? >> - one part of my overall goal is to clean up the tools/testing/selftests/bpf >> directory from anything that is not tested automatically. What should we do with >> the wrapping shell script (test_xdp_features.sh) ? Since test_progs will >> automate the test with veths, I guess it is still ok to just remove it ? >> >>> No preference but just to raise awareness - drivers/net's NetDrvEpEnv >>> class provides the setup for running tests with an endpoint. >>> XDP tests intended for HW would fit there pretty well. >> >> Thanks for the hint. If we want to keep some tooling for real hw xdp features >> testing, maybe we could add a small part in tools/testing/selftests/drivers/net >> and make it use this NetDrvEpEnv ? Or it is a bigger hint that the whole test >> about xdp features could be moved there (and then tested by net kselftests >> rather than by ebpf ci specifically) ? @Lorenzo and eBPF tests maintainers, any >> opinion ? >> >> Thanks, >> >> Alexis >> > >