From: Andrew Lunn <andrew@lunn.ch>
To: Fidan Aliyeva <fidan.aliyeva.ext@ericsson.com>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, marek.behun@nic.cz,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] mv88e6xxx: Cache scratch config of 6352 in setup
Date: Mon, 11 May 2026 01:06:41 +0200 [thread overview]
Message-ID: <6d2e8041-938f-4171-be40-9e0b0a2faa73@lunn.ch> (raw)
In-Reply-To: <20260510214518.2064192-1-fidan.aliyeva.ext@ericsson.com>
On Sun, May 10, 2026 at 11:45:18PM +0200, Fidan Aliyeva wrote:
> >
> > In mv88e6352 scratch register in Global Control 2 set of registers
> > returns which port is attached to SERDES. This value is set and
> > stays constant after the switch is released from reset; thus, it
> > can be cached during chip setup instead of reading the register
> > everytime when SERDES config is needed.
> >
> > 1. Add setup_chip_specific member to mv88e6xxx_ops and
> > g2_scratch_config3 member to mv88e6xxx_chip.
> > 2. Add mv88e6352_g2_cache_global_scratch_config3 function as
> > .setup_chip_specific which reads the CONFIG3 value from the scratch
> > register and caches it.
> > 3. Call .setup_chip_specific during chip setup.
> >
>
> Can we actually use setup_errata for this instead of adding a new member
> to mv88e6xxx_ops?
I was also thinking if there was another ops which could be used.
How about...
CONFIG3 holds the pin strapping values at reset. So how about
ops.reset?
Add a int mv88e6352_reset(struct mv88e6xxx_chip *chip) which first
calls mv88e6352_g1_reset() and then reads the scratch register?
Andrew
next prev parent reply other threads:[~2026-05-10 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 21:34 [RFC PATCH 1/1] mv88e6xxx: Cache scratch config of 6352 in setup Fidan Aliyeva
2026-05-10 21:45 ` Fidan Aliyeva
2026-05-10 23:06 ` Andrew Lunn [this message]
2026-05-10 23:13 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d2e8041-938f-4171-be40-9e0b0a2faa73@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidan.aliyeva.ext@ericsson.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox