From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, robh+dt@kernel.org,
bjorn.andersson@linaro.org, agross@kernel.org, mka@chromium.org,
evgreen@chromium.org, cpratapa@codeaurora.org,
avuyyuru@codeaurora.org, jponduru@codeaurora.org,
subashab@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: ipa: request IPA register values be retained
Date: Thu, 3 Feb 2022 05:22:23 -0600 [thread overview]
Message-ID: <6d303dbb-bdbc-bac1-526d-be593f329d23@linaro.org> (raw)
In-Reply-To: <20220202210248.6e3f92ef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2/2/22 11:02 PM, Jakub Kicinski wrote:
> On Tue, 1 Feb 2022 08:04:12 -0600 Alex Elder wrote:
>> Fixes: 2775cbc5afeb6 ("net: ipa: rename "ipa_clock.c"")
>
> The Fixes tag should point at the place the code was introduced,
> even if it moved or otherwise the patch won't apply as far back.
The problem was not "activated" until this commit:
1aac309d32075 net: ipa: use autosuspend
And that commit was merged together in a series that
included the one I mentioned above:
2775cbc5afeb6 net: ipa: rename "ipa_clock.c"
The rename commit is two commits after "use autosuspend".
The merge commit was:
863434886497d Merge branch 'ipa-autosuspend'
Until autosuspend is enabled, this new code is
completely unnecessary, so back-porting it beyond
that is pointless. I supplied the commit in the
"Fixes" tag because I thought it would be close
to equivalent and would avoid some trouble back-porting.
Perhaps the "use autosuspend" commit is the one that
should be in the "Fixes" tag, but I don't believe it
should be back-ported any further than that.
Re-spinning the series to fix the tag is trivial, but
before I do that, can you tell me which commit you
recommend I use in the "Fixes" tag?
The original commit that introduced the microcontroller
code (and also included the clock/power code) is:
a646d6ec90983 soc: qcom: ipa: modem and microcontroller
Thanks.
-Alex
next prev parent reply other threads:[~2022-02-03 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 14:04 [PATCH net 0/2] net: ipa: enable register retention Alex Elder
2022-02-01 14:04 ` [PATCH net 1/2] dt-bindings: net: qcom,ipa: add optional qcom,qmp property Alex Elder
2022-02-01 14:04 ` [PATCH net 2/2] net: ipa: request IPA register values be retained Alex Elder
2022-02-03 5:02 ` Jakub Kicinski
2022-02-03 11:22 ` Alex Elder [this message]
2022-02-03 16:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d303dbb-bdbc-bac1-526d-be593f329d23@linaro.org \
--to=elder@linaro.org \
--cc=agross@kernel.org \
--cc=avuyyuru@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=jponduru@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).