From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jose Abreu <Jose.Abreu@synopsys.com>
Subject: Re: [PATCH v3 net-next 3/9] net: stmmac: Add DMA related callbacks
 for XGMAC2
Date: Mon, 6 Aug 2018 08:56:17 +0100
Message-ID: <6d4bb8b9-0e2f-85d5-4e8d-b5c17cfe1d90@synopsys.com>
References: <cover.1533311285.git.joabreu@synopsys.com>
 <dfb48f95fffd5929e09186243445db6746e31bf5.1533311285.git.joabreu@synopsys.com>
 <dc666664-d93e-0408-cfd7-86b271191d3e@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>, <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtprelay.synopsys.com ([198.182.47.9]:55306 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725735AbeHFKEM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 6 Aug 2018 06:04:12 -0400
In-Reply-To: <dc666664-d93e-0408-cfd7-86b271191d3e@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 03-08-2018 19:58, Florian Fainelli wrote:
> On 08/03/2018 08:50 AM, Jose Abreu wrote:
>> Add the DMA related callbacks for the new IP block XGMAC2.
>>
>> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
>> Cc: David S. Miller <davem@davemloft.net>
>> Cc: Joao Pinto <jpinto@synopsys.com>
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> Cc: Alexandre Torgue <alexandre.torgue@st.com>
>> ---
>> +	value &= ~XGMAC_RD_OSR_LMT;
>> +	value |= (axi->axi_rd_osr_lmt << XGMAC_RD_OSR_LMT_SHIFT) &
>> +		XGMAC_RD_OSR_LMT;
>> +
>> +	for (i = 0; i < AXI_BLEN; i++) {
>> +		if (axi->axi_blen[i])
>> +			value &= ~XGMAC_UNDEF;
> Should not you be you clearing all XGMAC_BLEN* values since you do a
> logical or here? I am assuming this is not something that would likely
> change from one open/close but still?

Yeah, this won't change between open/close but I will add the
mask anyway.

Thanks and Best Regards,
Jose Miguel Abreu