* Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y
2022-02-04 15:59 [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y Jakub Kicinski
@ 2022-02-04 17:47 ` Florian Fainelli
2022-02-04 20:14 ` Arınç ÜNAL
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-02-04 17:47 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: netdev, Luiz Angelo Daros de Luca, Arınç ÜNAL,
linus.walleij, andrew, vivien.didelot, olteanv
On 2/4/2022 7:59 AM, Jakub Kicinski wrote:
> We generally default the vendor to y and the drivers itself
> to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> so it's not a pure "vendor selection" knob. Let's default it all
> to n.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y
2022-02-04 15:59 [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y Jakub Kicinski
2022-02-04 17:47 ` Florian Fainelli
@ 2022-02-04 20:14 ` Arınç ÜNAL
2022-02-04 23:55 ` Linus Walleij
2022-02-05 15:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 6+ messages in thread
From: Arınç ÜNAL @ 2022-02-04 20:14 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: netdev, Luiz Angelo Daros de Luca, linus.walleij, andrew,
vivien.didelot, f.fainelli, olteanv
On 04/02/2022 18:59, Jakub Kicinski wrote:
> We generally default the vendor to y and the drivers itself
> to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> so it's not a pure "vendor selection" knob. Let's default it all
> to n.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Happy to drop this if someone has a better patch, e.g. making
> NET_DSA_REALTEK a pure vendor knob!
>
> CC: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> CC: Arınç ÜNAL <arinc.unal@arinc9.com>
> CC: linus.walleij@linaro.org
> CC: andrew@lunn.ch
> CC: vivien.didelot@gmail.com
> CC: f.fainelli@gmail.com
> CC: olteanv@gmail.com
> ---
> drivers/net/dsa/realtek/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
> index 5242698143d9..b7427a8292b2 100644
> --- a/drivers/net/dsa/realtek/Kconfig
> +++ b/drivers/net/dsa/realtek/Kconfig
> @@ -12,7 +12,6 @@ menuconfig NET_DSA_REALTEK
> config NET_DSA_REALTEK_MDIO
> tristate "Realtek MDIO connected switch driver"
> depends on NET_DSA_REALTEK
> - default y
> help
> Select to enable support for registering switches configured
> through MDIO.
> @@ -20,14 +19,12 @@ config NET_DSA_REALTEK_MDIO
> config NET_DSA_REALTEK_SMI
> tristate "Realtek SMI connected switch driver"
> depends on NET_DSA_REALTEK
> - default y
> help
> Select to enable support for registering switches connected
> through SMI.
>
> config NET_DSA_REALTEK_RTL8365MB
> tristate "Realtek RTL8365MB switch subdriver"
> - default y
> depends on NET_DSA_REALTEK
> depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO
> select NET_DSA_TAG_RTL8_4
> @@ -36,7 +33,6 @@ config NET_DSA_REALTEK_RTL8365MB
>
> config NET_DSA_REALTEK_RTL8366RB
> tristate "Realtek RTL8366RB switch subdriver"
> - default y
> depends on NET_DSA_REALTEK
> depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO
> select NET_DSA_TAG_RTL4_A
Looks good to me.
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Cheers.
Arınç
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y
2022-02-04 15:59 [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y Jakub Kicinski
2022-02-04 17:47 ` Florian Fainelli
2022-02-04 20:14 ` Arınç ÜNAL
@ 2022-02-04 23:55 ` Linus Walleij
2022-02-05 18:14 ` Luiz Angelo Daros de Luca
2022-02-05 15:20 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2022-02-04 23:55 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, Luiz Angelo Daros de Luca,
Arınç ÜNAL, andrew, vivien.didelot, f.fainelli,
olteanv
On Fri, Feb 4, 2022 at 4:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
> We generally default the vendor to y and the drivers itself
> to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> so it's not a pure "vendor selection" knob. Let's default it all
> to n.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Fair enough,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y
2022-02-04 23:55 ` Linus Walleij
@ 2022-02-05 18:14 ` Luiz Angelo Daros de Luca
0 siblings, 0 replies; 6+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-02-05 18:14 UTC (permalink / raw)
To: Linus Walleij
Cc: Jakub Kicinski, David S. Miller, open list:NETWORKING DRIVERS,
Arınç ÜNAL, Andrew Lunn, Vivien Didelot,
Florian Fainelli, Vladimir Oltean
Em sex., 4 de fev. de 2022 20:55, Linus Walleij
<linus.walleij@linaro.org> escreveu:
>
> On Fri, Feb 4, 2022 at 4:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> > We generally default the vendor to y and the drivers itself
> > to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> > so it's not a pure "vendor selection" knob. Let's default it all
> > to n.
Whatever fits better In the kernel default settings policy. The
devices where that driver will be used normally work with custom built
kernels. The default values have little importance.
Acked-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y
2022-02-04 15:59 [PATCH net-next] net: dsa: realtek: don't default Kconfigs to y Jakub Kicinski
` (2 preceding siblings ...)
2022-02-04 23:55 ` Linus Walleij
@ 2022-02-05 15:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-05 15:20 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, luizluca, arinc.unal, linus.walleij, andrew,
vivien.didelot, f.fainelli, olteanv
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 4 Feb 2022 07:59:27 -0800 you wrote:
> We generally default the vendor to y and the drivers itself
> to n. NET_DSA_REALTEK, however, selects a whole bunch of things,
> so it's not a pure "vendor selection" knob. Let's default it all
> to n.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: realtek: don't default Kconfigs to y
https://git.kernel.org/netdev/net-next/c/3115ff3c9d3c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread