From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Egil Hjelmeland <privat@egil-hjelmeland.no>
Subject: Re: [PATCH] net: dsa: lan9303: fix variable 'res' set but not used
Date: Sun, 5 Jul 2020 13:56:38 -0700 [thread overview]
Message-ID: <6dac26c6-aa9c-2990-6c21-9fc2a64f9fde@gmail.com> (raw)
In-Reply-To: <20200705205555.893062-1-andrew@lunn.ch>
On 7/5/2020 1:55 PM, Andrew Lunn wrote:
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland <privat@egil-hjelmeland.no>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-05 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 20:55 [PATCH] net: dsa: lan9303: fix variable 'res' set but not used Andrew Lunn
2020-07-05 20:56 ` Florian Fainelli [this message]
2020-07-05 22:48 ` David Miller
2020-07-05 22:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dac26c6-aa9c-2990-6c21-9fc2a64f9fde@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox