From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Russkikh Subject: Re: aquantia - BUG: unable to handle kernel NULL pointer dereference at 0000000000000058 on reboot Date: Tue, 10 Apr 2018 15:53:39 +0300 Message-ID: <6df8b628-cec5-9ce5-8430-e9a2cd27346d@aquantia.com> References: <5a5882e07351e92a5d57ea6d1b91fcab55e466bf.camel@declera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev To: Yanko Kaneti Return-path: Received: from mail-sn1nam01on0082.outbound.protection.outlook.com ([104.47.32.82]:38432 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752735AbeDJMxy (ORCPT ); Tue, 10 Apr 2018 08:53:54 -0400 In-Reply-To: <5a5882e07351e92a5d57ea6d1b91fcab55e466bf.camel@declera.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10.04.2018 15:42, Yanko Kaneti wrote: > Hello, > > Since 90869ddfefeb net: aquantia: Implement pci shutdown callback > I get the below oops on reboot. Without the callback everything works > as expected. > Thanks, we also recently found out that. Could you please try the below patch? diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index c96a921..32f6d2e 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -951,9 +951,11 @@ void aq_nic_shutdown(struct aq_nic_s *self) netif_device_detach(self->ndev); - err = aq_nic_stop(self); - if (err < 0) - goto err_exit; + if (netif_running(self->ndev)) { + err = aq_nic_stop(self); + if (err < 0) + goto err_exit; + } aq_nic_deinit(self); err_exit: -- 2.7.4