From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 iproute2-next] utils: add fflush_monitor() helper
Date: Thu, 30 Apr 2026 09:35:08 -0600 [thread overview]
Message-ID: <6e00eaa5-a4d7-45dd-9d90-fb319b76c9fa@kernel.org> (raw)
In-Reply-To: <20260427081953.364819-1-edumazet@google.com>
On 4/27/26 2:19 AM, Eric Dumazet wrote:
> Some fflush() calls only make sense for monitor programs.
>
> For other cases, forcing a flush is expensive.
>
> After this patch, ip, tc and ss are correctly buffering most of their
> output when redirected to a file.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/utils.h | 7 +++++++
> ip/ipaddress.c | 12 +++++++-----
> ip/iplink.c | 4 ++--
> ip/ipmonitor.c | 1 +
> ip/ipmptcp.c | 10 +++++-----
> ip/ipneigh.c | 4 ++--
> ip/ipnetconf.c | 2 +-
> ip/ipnetns.c | 2 +-
> ip/ipnexthop.c | 12 ++++++------
> ip/iproute.c | 4 ++--
> ip/iprule.c | 2 +-
> ip/iptoken.c | 2 +-
> ip/tcp_metrics.c | 2 +-
> lib/utils.c | 1 +
> misc/ss.c | 3 ++-
> tc/tc_class.c | 2 +-
> tc/tc_filter.c | 2 +-
> tc/tc_monitor.c | 1 +
> tc/tc_qdisc.c | 2 +-
> 19 files changed, 44 insertions(+), 31 deletions(-)
>
no longer applies after merging main to next.
next prev parent reply other threads:[~2026-04-30 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 8:19 [PATCH v2 iproute2-next] utils: add fflush_monitor() helper Eric Dumazet
2026-04-27 16:31 ` Stephen Hemminger
2026-04-27 16:47 ` Eric Dumazet
2026-04-30 15:35 ` David Ahern [this message]
2026-04-30 15:36 ` Eric Dumazet
2026-05-01 15:10 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e00eaa5-a4d7-45dd-9d90-fb319b76c9fa@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox