From: David Ahern <dsahern@gmail.com>
To: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH net] ipv6: release rt6->rt6i_idev properly during ifdown
Date: Mon, 14 Aug 2017 13:05:16 -0600 [thread overview]
Message-ID: <6e1bb883-8d44-fcf6-4d2e-6c1ccd0ca95e@gmail.com> (raw)
In-Reply-To: <20170814174459.3569-1-tracywwnj@gmail.com>
On 8/14/17 11:44 AM, Wei Wang wrote:
> From: Wei Wang <weiwan@google.com>
>
> When a dst is created by addrconf_dst_alloc() for a host route or an
> anycast route, dst->dev points to loopback dev while rt6->rt6i_idev
> points to a real device.
> When the real device goes down, the current cleanup code only checks for
> dst->dev and assumes rt6->rt6i_idev->dev is the same. This causes the
> refcount leak on the real device in the above situation.
> This patch makes sure to always release the refcount taken on
> rt6->rt6i_idev during dst_dev_put().
>
> Fixes: 587fea741134 ("ipv6: mark DST_NOGC and remove the operation of
> dst_free()")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> Tested-by: Martin KaFai Lau <kafai@fb.com>
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> ---
> net/ipv6/route.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2017-08-14 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 17:44 [PATCH net] ipv6: release rt6->rt6i_idev properly during ifdown Wei Wang
2017-08-14 19:05 ` David Ahern [this message]
2017-08-15 5:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e1bb883-8d44-fcf6-4d2e-6c1ccd0ca95e@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).