Re: [RFC v2 1/3] net: phy: mediatek: add phy driver for MT7628 built-in Fast Ethernet PHYs

[Andrew Lunn <andrew@lunn.ch>]

> diff --git a/drivers/net/phy/mediatek/Kconfig b/drivers/net/phy/mediatek/Kconfig
> index bb7dc876271e..62355d46cb1e 100644
> --- a/drivers/net/phy/mediatek/Kconfig
> +++ b/drivers/net/phy/mediatek/Kconfig
> @@ -36,5 +36,11 @@ config MEDIATEK_GE_SOC_PHY
>  	  present in the SoCs efuse and will dynamically calibrate VCM
>  	  (common-mode voltage) during startup.
>  
> +config MEDIATEK_FE_SOC_PHY
> +	tristate "MediaTek MT7628 SoC Ethernet PHYs"
> +	select PHY_PACKAGE
> +	help
> +	  Support for MediaTek MT7628 built-in Fast Ethernet PHYs.
> +

This file is sorted by tristate string.

It might be best to change:

config MEDIATEK_GE_SOC_PHY
-        tristate "MediaTek SoC Ethernet PHYs"
+        tristate "MediaTek SoC Gigabit Ethernet PHYs"

And then you can add

> +config MEDIATEK_FE_SOC_PHY
> +	tristate "MediaTek SoC Fast Ethernet PHYs"

before?

Also, why do you have `select PHY_PACKAGE`?

>  obj-$(CONFIG_MEDIATEK_2P5GE_PHY)	+= mtk-2p5ge.o
>  obj-$(CONFIG_MEDIATEK_GE_PHY)		+= mtk-ge.o
>  obj-$(CONFIG_MEDIATEK_GE_SOC_PHY)	+= mtk-ge-soc.o
> +obj-$(CONFIG_MEDIATEK_FE_SOC_PHY)	+= mtk-fe-soc.o
>  obj-$(CONFIG_MTK_NET_PHYLIB)		+= mtk-phy-lib.o

Please sort alphabetically. 

> +static struct phy_driver mtk_soc_fe_phy_driver[] = {
> +	{
> +		PHY_ID_MATCH_EXACT(MTK_FPHY_ID_MT7628),
> +		.name = "MediaTek MT7628 PHY",
> +		.config_init = mt7628_phy_config_init,
> +		.config_intr = genphy_no_config_intr,
> +		.handle_interrupt = genphy_handle_interrupt_no_ack,

How do interrupts work in this device? Has this been simply
cut/pasted, or have interrupts been tested using these functions?

	Andrew