From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
alexei.starovoitov@gmail.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH bpf 0/2] tools: bpftool: small fixes for error handling in prog load
Date: Thu, 21 Jun 2018 23:10:59 +0200 [thread overview]
Message-ID: <6e324137-fa4d-df80-902e-ae318d2bd3cd@iogearbox.net> (raw)
In-Reply-To: <20180620184246.18672-1-jakub.kicinski@netronome.com>
On 06/20/2018 08:42 PM, Jakub Kicinski wrote:
> Hi!
>
> Two small fixes for error handling in bpftool prog load, first patch
> removes a duplicated message, second one frees resources correctly.
> Multiple error messages break JSON:
>
> # bpftool -jp prog load tracex1_kern.o /sys/fs/bpf/a
> {
> "error": "can't pin the object (/sys/fs/bpf/a): File exists"
> },{
> "error": "failed to pin program"
> }
>
> Jakub Kicinski (2):
> tools: bpftool: remove duplicated error message on prog load
> tools: bpftool: remember to close the libbpf object on prog load error
>
> tools/bpf/bpftool/prog.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Applied to bpf, thanks Jakub!
prev parent reply other threads:[~2018-06-21 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 18:42 [PATCH bpf 0/2] tools: bpftool: small fixes for error handling in prog load Jakub Kicinski
2018-06-20 18:42 ` [PATCH bpf 1/2] tools: bpftool: remove duplicated error message on " Jakub Kicinski
2018-06-21 5:36 ` Song Liu
2018-06-20 18:42 ` [PATCH bpf 2/2] tools: bpftool: remember to close the libbpf object after " Jakub Kicinski
2018-06-21 5:37 ` Song Liu
2018-06-21 21:10 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e324137-fa4d-df80-902e-ae318d2bd3cd@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox