From: Jan Vaclav <jvaclav@redhat.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] net/hsr: add protocol version to fill_info output
Date: Tue, 14 Oct 2025 10:54:48 +0200 [thread overview]
Message-ID: <6e7b63e0-65f5-4920-8908-f6f6ede9716b@redhat.com> (raw)
In-Reply-To: <b25a73bf-1309-4f9f-9cd7-795e0615635b@suse.de>
On 14.10.2025 10:48, Fernando Fernandez Mancera wrote:
> On 10/9/25 11:09 PM, Jan Vaclav wrote:
>> Currently, it is possible to configure IFLA_HSR_VERSION, but
>> there is no way to check in userspace what the currently
>> configured HSR protocol version is.
>>
>> Add it to the output of hsr_fill_info(), when the interface
>> is using the HSR protocol. Let's not expose it when using
>> the PRP protocol, since it only has one version and it's
>> not possible to set it from userspace.
>>
>> This info could then be used by e.g. ip(8), like so:
>> $ ip -d link show hsr0
>> 12: hsr0: <BROADCAST,MULTICAST> mtu ...
>> ...
>> hsr slave1 veth0 slave2 veth1 ... proto 0 version 1
>
> I think this is missing the 'Signed-off-by' tag. Other than that, it
> looks good to me. Not sure if it can be added while merging.
>
> Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
>
Yes, it looks like I dropped my signoff somewhere along the way, my
apologies. If it's possible to add it while merging, please consider
this patch as:
Signed-off-by: Jan Vaclav <jvaclav@redhat.com>
next prev parent reply other threads:[~2025-10-14 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 21:09 [PATCH v3 net-next] net/hsr: add protocol version to fill_info output Jan Vaclav
2025-10-14 8:48 ` Fernando Fernandez Mancera
2025-10-14 8:54 ` Jan Vaclav [this message]
2025-10-14 12:20 ` Andrew Lunn
2025-10-14 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e7b63e0-65f5-4920-8908-f6f6ede9716b@redhat.com \
--to=jvaclav@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).