From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gal Pressman Subject: Re: [PATCH v2] net/mlx5: Delete unneeded function argument Date: Thu, 16 Aug 2018 13:31:21 +0300 Message-ID: <6e7d5c26-2a21-2bbc-8356-3d23c2bad29d@gmail.com> References: <20180815150854.30993-1-yuval.shaia@oracle.com> <20180816090006.GB4318@lap1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: saeedm@mellanox.com, leon@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org To: Yuval Shaia Return-path: Received: from mail-ed1-f66.google.com ([209.85.208.66]:46812 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeHPN3C (ORCPT ); Thu, 16 Aug 2018 09:29:02 -0400 In-Reply-To: <20180816090006.GB4318@lap1> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 16-Aug-18 12:00, Yuval Shaia wrote: > On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote: >> On 15-Aug-18 18:08, Yuval Shaia wrote: >>> priv argument is not used by the function, delete it. >>> >>> Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") >>> Signed-off-by: Yuval Shaia >> >> nit: prefix should be net/mlx5e. > > 1. Will do. > 2. Why? (asking since dir name is mlx5) Core related changes use net/mlx5 prefix, Ethernet related changes (en_* files) use net/mlx5e prefix. Same thought goes into function names prefix (mlx5_*/mlx5e_*). > >> >>> --- >>> v1 -> v2: >>> * Remove blank line as pointed by Leon. >>> --- >>> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c >>> index 1646859974ce..4c4d779dafa8 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c >>> @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = { >>> >>> #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc) >>> >>> -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv) >>> +static int mlx5e_grp_per_prio_traffic_get_num_stats(void) >>> { >>> return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO; >>> } >>> @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv, >>> >>> static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv) >>> { >>> - return mlx5e_grp_per_prio_traffic_get_num_stats(priv) + >>> + return mlx5e_grp_per_prio_traffic_get_num_stats() + >>> mlx5e_grp_per_prio_pfc_get_num_stats(priv); >>> } >>> >>> >>