From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Neal Cardwell" <ncardwell@google.com>,
"Yuchung Cheng" <ycheng@google.com>,
"Soheil Hassas Yeganeh" <soheil@google.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next 3/6] tcp: add SACK compression
Date: Thu, 17 May 2018 13:41:21 -0700 [thread overview]
Message-ID: <6e8e3303-f267-4952-cf17-7218469e0656@gmail.com> (raw)
In-Reply-To: <20180517174739.192489-4-edumazet@google.com>
On 05/17/2018 10:47 AM, Eric Dumazet wrote:
> + /* compress ack timer : 5 % of srtt, but no more than 1 ms */
> +
> + delay = min_t(unsigned long, NSEC_PER_MSEC,
> + tp->rcv_rtt_est.rtt_us * (NSEC_PER_USEC >> 3)/20);
>
Yuchung suggested that we use min(rtt, rcv_rtt), and I totally agree with him.
I will send a v3 with this suggestion.
next prev parent reply other threads:[~2018-05-17 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 17:47 [PATCH v2 net-next 0/6] tcp: implement SACK compression Eric Dumazet
2018-05-17 17:47 ` [PATCH v2 net-next 1/6] tcp: use __sock_put() instead of sock_put() in tcp_clear_xmit_timers() Eric Dumazet
2018-05-17 17:47 ` [PATCH v2 net-next 2/6] tcp: do not force quickack when receiving out-of-order packets Eric Dumazet
2018-05-17 17:47 ` [PATCH v2 net-next 3/6] tcp: add SACK compression Eric Dumazet
2018-05-17 20:41 ` Eric Dumazet [this message]
2018-05-17 17:47 ` [PATCH v2 net-next 4/6] tcp: add TCPAckCompressed SNMP counter Eric Dumazet
2018-05-17 17:47 ` [PATCH v2 net-next 5/6] tcp: add tcp_comp_sack_delay_ns sysctl Eric Dumazet
2018-05-17 17:47 ` [PATCH v2 net-next 6/6] tcp: add tcp_comp_sack_nr sysctl Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8e3303-f267-4952-cf17-7218469e0656@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=toke@toke.dk \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox