From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arkadi Sharshevsky Subject: Re: [patch net-next RFC v2 07/11] mlxsw: spectrum: Register KVD resources with devlink Date: Wed, 15 Nov 2017 12:01:33 +0200 Message-ID: <6e944c21-e37b-4ea9-dfa2-d087d3984192@mellanox.com> References: <20171114161852.6633-1-jiri@resnulli.us> <20171114161852.6633-8-jiri@resnulli.us> <6aa790a9-0a22-e85e-b7ac-4853cd254b47@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, linville@tuxdriver.com, gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com To: David Ahern , Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-eopbgr10045.outbound.protection.outlook.com ([40.107.1.45]:8258 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755215AbdKOKBq (ORCPT ); Wed, 15 Nov 2017 05:01:46 -0500 In-Reply-To: <6aa790a9-0a22-e85e-b7ac-4853cd254b47@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/15/2017 02:15 AM, David Ahern wrote: > On 11/14/17 9:18 AM, Jiri Pirko wrote: >> +static int >> +mlxsw_sp_resource_kvd_size_validate(struct devlink *devlink, u64 size, >> + struct list_head *resource_list, >> + struct netlink_ext_ack *extack) >> +{ >> + struct mlxsw_core *mlxsw_core = devlink_priv(devlink); >> + u32 kvd_size, single_size, double_size, linear_size; >> + struct devlink_resource *resource; >> + >> + kvd_size = MLXSW_CORE_RES_GET(mlxsw_core, KVD_SIZE); >> + if (kvd_size != size) { >> + NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "kvd size cannot be chagned"); >> + return -EINVAL; >> + } >> + >> + list_for_each_entry(resource, resource_list, list) { >> + switch (resource->id) { >> + case MLXSW_SP_RESOURCE_KVD_LINEAR: >> + linear_size = resource->size_new; >> + break; >> + case MLXSW_SP_RESOURCE_KVD_HASH_SINGLE: >> + single_size = resource->size_new; >> + break; >> + case MLXSW_SP_RESOURCE_KVD_HASH_DOUBLE: >> + double_size = resource->size_new; >> + break; >> + } >> + } >> + >> + /* Overlap is not supported */ >> + if (linear_size + single_size + double_size > kvd_size) { >> + NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Overlap is not supported"); >> + return -EINVAL; >> + } >> + >> + return 0; >> +} >> + > > gcc warnings due to the above: > > /home/dsa/kernel-3.git/drivers/net/ethernet/mellanox/mlxsw/spectrum.c: > In function ‘mlxsw_sp_resource_kvd_size_validate’: > /home/dsa/kernel-3.git/drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3974:32: > warning: ‘linear_size’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > if (linear_size + single_size + double_size > kvd_size) { > ^ > /home/dsa/kernel-3.git/drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3950:29: > warning: ‘double_size’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > u32 kvd_size, single_size, double_size, linear_size; > ^ > /home/dsa/kernel-3.git/drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3950:16: > warning: ‘single_size’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > u32 kvd_size, single_size, double_size, linear_size; > ^ > Thanks, will fix