netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baozeng Ding <sploving1@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: net/ipv6: potential deadlock in do_ipv6_setsockopt
Date: Wed, 19 Oct 2016 15:45:56 +0800	[thread overview]
Message-ID: <6e9dbe30-ec0f-07cb-0e16-d86eb4bc480f@gmail.com> (raw)
In-Reply-To: <ec7e340c-132f-549d-9c30-b6e903cc7666@gmail.com>

It fixes the issue for me. 
Tested-by: Baozeng Ding <sploving1@gmail.com>

On 2016/10/17 17:54, Baozeng Ding wrote:
> Applied the patch to my test tree. I will tell you the result a few days later. Thank you.
> 
> On 2016/10/17 2:50, Cong Wang wrote:
>> On Sun, Oct 16, 2016 at 6:34 AM, Baozeng Ding <sploving1@gmail.com> wrote:
>>>  Possible unsafe locking scenario:
>>>
>>>        CPU0                    CPU1
>>>        ----                    ----
>>>   lock([  165.136033] sk_lock-AF_INET6
>>> );
>>>                                lock([  165.136033] rtnl_mutex
>>> );
>>>                                lock([  165.136033] sk_lock-AF_INET6
>>> );
>>>   lock([  165.136033] rtnl_mutex
>>> );
>>>
>>>  *** DEADLOCK ***
>>
>> This is caused by the conditional rtnl locking in do_ipv6_setsockopt().
>> It looks like we miss the case of IPV6_ADDRFORM.
>>
>> Please try the attached patch.
>>

  reply	other threads:[~2016-10-19 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16 13:34 net/ipv6: potential deadlock in do_ipv6_setsockopt Baozeng Ding
2016-10-16 18:50 ` Cong Wang
2016-10-17  9:54   ` Baozeng Ding
2016-10-19  7:45     ` Baozeng Ding [this message]
2016-10-19 16:36       ` Cong Wang
2016-10-19 13:44     ` Baozeng Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e9dbe30-ec0f-07cb-0e16-d86eb4bc480f@gmail.com \
    --to=sploving1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).