From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC534AD4AE for ; Fri, 25 Sep 2026 18:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790361612; cv=none; b=ufkUup2mdB5j5l/HpDH1Fb7lUOuYvdYRcdwswdTcMXjEShz8zDXicBBmKfeDZvXJB8/l6n9l8vu3oL6/UaqoGOHIhx9d3FXFfkUx6rTj1vqSag6SezMu5l/0Yh82lPowZUZButPdjUq2aeIrPP7QYBcqYmQU1WTpCZr1Wj/OH4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790361612; c=relaxed/simple; bh=yTmgTQzTksTHa8o2UxqQ6icHIyr/7uwYb6SrpbVzA70=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PXOvuj/tFU7vw/OxFLcIzARwicbFR98o9nEbHj+bDsgX+vUJc1Q3hL91HHm2LFL7QK4SlBKiIYFKHfQSLaSjvnfQmWXijptQFpyoDU/sv7SsFb+mCYw7kiFgwHCn54xn3QDm94eHJfENk2/qLKoGfvjOGcrQDZszvl+4AuiGm10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=hXniebDx; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="hXniebDx" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68PG5nCX343636; Fri, 25 Sep 2026 18:39:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=Evpe9IJKv2lTTtmgm Sw/z+nWiwE9Q/Q8T0WEwrdaHhs=; b=hXniebDxgZMfYbuTQpg07bq7uYpOmZDXh NFDtfpcxIepohvD/XMwOxWFO5iYZs+2yrUFnvi9UD0N/ju0dfo1Qg7VtzSptn68A JusePgV22X/eVPWqXit2PJC2ICDEWGLUcDfKE5sOU9S3zAlpTnFZHDz3s1Hj/RwR MZOFDlvWyseNisj7aQKvOGrs3qXS0W2Qjj6J/LUbUVITYZr0n3tQpAQKw7rcHRnQ /IUsTMF6hxohwEQf6gb2YTOHzw0KPvupPL5LkirgYNVdVKV5DtUz6N8qSSd/+cKZ 38+aE1+E7Em1LYS+JWncM5q1JFVpPe2Qy8oGeqfYrxduWv9g8BGxQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgqyjer-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 25 Sep 2026 18:39:55 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68PHtFqZ074573; Fri, 25 Sep 2026 18:39:54 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gwwsfr52g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Sep 2026 18:39:54 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68PIdpY335914020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Sep 2026 18:39:51 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E5AB5804B; Fri, 25 Sep 2026 18:39:51 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADD4458055; Fri, 25 Sep 2026 18:39:48 +0000 (GMT) Received: from localhost.localdomain (unknown [9.67.6.174]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 25 Sep 2026 18:39:48 +0000 (GMT) From: Mingming Cao To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, horms@kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, nnac123@linux.ibm.com, maddy@linux.ibm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, haren@linux.ibm.com, ricklind@linux.ibm.com, davemarq@linux.ibm.com, bjking1@linux.ibm.com, shaik.abdulla1@ibm.com, Mingming Cao Subject: [PATCH net-next v7 13/15] ibmveth: Expose per-queue buffer pool details via debugfs Date: Fri, 25 Sep 2026 11:38:48 -0700 Message-Id: <6ea43868c2fd9ed4fb55f412c637a002d7c357c3.1790319558.git.mmc@linux.ibm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ab6bffb cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=Oho_uL6CWHW3JcStrLEA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDA3NCBTYWx0ZWRfX4CgO3t30wqwR VYCMWRWmurf8rik6hxuAzt0DVwT8nxLxgyBNGywIeP8B/YH5m9u0EX9l59Md9cR2L8U9l8UpEpY 6VPeZEOJ2jWvNl9Jfb3QxFjsq2fTSEdaezukTJndxF8iZxPPGrBt4qPx0rGtFQd+YuQ3GY+7TBV odPJwpyoM8YybGXNCt9/JC+58/ZADt+//HZ/PXT0+upOdPU11UFGjp+aFMPPHg+LamawGSrknAT q7NRQoT4cgwTbSfU2EGEltiILLjyMA06vswiDWOWJMEPX2D8bPFtOyoYv0VESMbFqolRjnbSCo4 /nLCNtCtHj/rzszdwgqyGNEETINUlmJRItS6ZjAJoK2ejzo/ya8iwsfN5EwwGeK3eroO57vlDoW EBuP9YKKkIUOffMzaqWlTYEejWByNVRYr+0ulBLSejVXSB3C9hnGF1eEeZa207ARScA868UDneg 822XPevNczgAA3pm/lQ== X-Proofpoint-ORIG-GUID: NTjifk1E9k6uU1h1jRizg5l9l51csWE1 X-Proofpoint-GUID: 8MNz30X3YD9hQPQLu1ayYyBdjeLVU__c X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDA3NCBTYWx0ZWRfXwFZczmYLQBAW TJV3sWtwveAR8TaTnFoyNe7hYP/NKpnPZPItcnxgQWp8T2f5dmxdZDZCejkfbNgIIMm4d3x6vTF RMaiH+HmMql3yaLu/QLdr/E6vsNJRBM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250074 With multi-queue RX each queue owns its own set of five buffer pools, so a 16-queue adapter has 80 of them. Nothing reports their runtime state: sysfs exposes queue 0 only, and only as configuration, and no ethtool key is per-pool. When RX drops under load, rx%d_no_buffer_drops names the queue but not which of its pools ran dry, nor how close the others are. Add a read-only buffer_pools debugfs file, one row per RX queue and buffer pool: /sys/kernel/debug/ibmveth//buffer_pools (e.g. /sys/kernel/debug/ibmveth/30000002/buffer_pools) Queue Pool Count BuffSize Active Available Active is live allocation (skbuff && free_map), not the sysfs poolN/active configuration flag. The root is driver-owned so each adapter directory can use its stable vio name rather than the mutable netdev->name. It is created in module_init() and unwound if vio_register_driver() fails. A multi-line table does not belong in sysfs, so the historical queue-0 ABI is left alone: .../poolN/{active,num,size} Those stay one-value configuration for queue-0 pool classes. Open copies that geometry to queues 1..N. This series does not add per-queue pool sysfs dirs. Signed-off-by: Mingming Cao Reviewed-by: Dave Marquardt Tested-by: Shaik Abdulla --- Changes in v7: - no P13 code change Changes in v6: - create the debugfs root in module_init() instead of lazily on first probe, which raced concurrent probes and could orphan the directory on ERR_PTR(-EEXIST) - rename the pool buffer-count column from Size to Count, so the debugfs table stops reusing the word sysfs poolN/size spells as a byte length on the same pool object - widen the down banner: geometry above queue 0 is only populated once open copies the queue-0 template - scope the dump RTNL comment to geometry/pool->active; available is atomic_read Changes in v5: - debugfs buffer_pools_show walks get_num_rx_queues() - Series renumber: mailed v4 11/14 debugfs -> tip P13 (14->15) - Path uses stable vio dev_name under a driver-owned root (not netdev name - avoids rename/collide) - rtnl_lock around dump (writers are under RTNL) - Show Active/Available as 0 when pool !live (debugfs view; free-path available clear already in the buffer-submit patch) Changes in v4: - Move the all-queue buffer_pools diagnostic from sysfs to debugfs; subject updated to match. - Keep historical queue-0 poolN/{active,num,size} sysfs as one-value config (template for MQ); do not add per-queue pool sysfs dirs. drivers/net/ethernet/ibm/ibmveth.c | 80 +++++++++++++++++++++++++++++- drivers/net/ethernet/ibm/ibmveth.h | 2 + 2 files changed, 81 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index cd2e5e4a81fe..0ac0359bb71e 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -3536,6 +3537,67 @@ static const struct net_device_ops ibmveth_netdev_ops = { #endif }; +static int ibmveth_buffer_pools_show(struct seq_file *m, void *v) +{ + struct ibmveth_adapter *adapter = m->private; + int i, j; + + /* + * size / buff_size / pool->active are written under RTNL + * (veth_pool_store, open template copy). Take the same lock so + * those columns are not a torn snapshot. available is updated + * from NAPI/softirq; only atomic_read() keeps it from tearing. + * Not required for memory safety; embedded arrays only. + */ + rtnl_lock(); + + seq_puts(m, "Queue Pool Count BuffSize Active Available\n"); + seq_puts(m, "----- ---- ----- -------- ------ ---------\n"); + if (!adapter->opened) { + seq_puts(m, "# down: Active/Available 0 unless allocated\n"); + seq_puts(m, "# down: geometry above queue 0 set at open\n"); + } + + for (i = 0; i < ibmveth_get_num_rx_queues(adapter); i++) { + for (j = 0; j < IBMVETH_NUM_BUFF_POOLS; j++) { + struct ibmveth_buff_pool *pool = + &adapter->rx_buff_pool[i][j]; + bool live = pool->skbuff && pool->free_map; + int active = live ? pool->active : 0; + int available = live ? atomic_read(&pool->available) + : 0; + + seq_printf(m, "%5d %4d %5u %8u %6d %9d\n", + i, j, pool->size, pool->buff_size, + active, available); + } + } + + rtnl_unlock(); + return 0; +} +DEFINE_SHOW_ATTRIBUTE(ibmveth_buffer_pools); + +/* Driver-owned root so per-adapter dirs use a stable vio name, not the + * mutable netdev->name (avoids stale names / eth0 collisions after rename). + */ +static struct dentry *ibmveth_dbg_root; + +static void ibmveth_debugfs_init(struct ibmveth_adapter *adapter) +{ + adapter->debugfs_dir = + debugfs_create_dir(dev_name(&adapter->vdev->dev), + ibmveth_dbg_root); + debugfs_create_file("buffer_pools", 0400, adapter->debugfs_dir, + adapter, &ibmveth_buffer_pools_fops); +} + +static void ibmveth_debugfs_exit(struct ibmveth_adapter *adapter) +{ + debugfs_remove_recursive(adapter->debugfs_dir); + adapter->debugfs_dir = NULL; +} + /** * ibmveth_pool_kobj_release - Mark a pool kobject finished * @kobj: kobject embedded in the pool @@ -3799,6 +3861,8 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) netdev_dbg(netdev, "registered\n"); + ibmveth_debugfs_init(adapter); + return 0; } @@ -3807,6 +3871,8 @@ static void ibmveth_remove(struct vio_dev *dev) struct net_device *netdev = dev_get_drvdata(&dev->dev); struct ibmveth_adapter *adapter = netdev_priv(netdev); + ibmveth_debugfs_exit(adapter); + ibmveth_put_pool_kobjs(adapter, IBMVETH_NUM_BUFF_POOLS); /* @@ -4032,15 +4098,27 @@ static struct vio_driver ibmveth_driver = { static int __init ibmveth_module_init(void) { + int rc; + printk(KERN_DEBUG "%s: %s %s\n", ibmveth_driver_name, ibmveth_driver_string, ibmveth_driver_version); - return vio_register_driver(&ibmveth_driver); + ibmveth_dbg_root = debugfs_create_dir(ibmveth_driver_name, NULL); + + rc = vio_register_driver(&ibmveth_driver); + if (rc) { + debugfs_remove_recursive(ibmveth_dbg_root); + ibmveth_dbg_root = NULL; + } + + return rc; } static void __exit ibmveth_module_exit(void) { vio_unregister_driver(&ibmveth_driver); + debugfs_remove_recursive(ibmveth_dbg_root); + ibmveth_dbg_root = NULL; } module_init(ibmveth_module_init); diff --git a/drivers/net/ethernet/ibm/ibmveth.h b/drivers/net/ethernet/ibm/ibmveth.h index b35da8bdce5f..11eda224a680 100644 --- a/drivers/net/ethernet/ibm/ibmveth.h +++ b/drivers/net/ethernet/ibm/ibmveth.h @@ -386,6 +386,8 @@ struct ibmveth_adapter { struct ibmveth_rx_queue_stats *rx_qstats; struct ibmveth_tx_queue_stats *tx_qstats; + struct dentry *debugfs_dir; + /* Ethtool settings */ u8 duplex; u32 speed; -- 2.50.1 (Apple Git-155)