From: David Ahern <dsahern@gmail.com>
To: Jeffrey Ji <jeffreyjilinux@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Brian Vazquez <brianvv@google.com>,
netdev@vger.kernel.org, Jeffrey Ji <jeffreyji@google.com>
Subject: Re: [PATCH iproute2-next v2] show rx_otherehost_dropped stat in ip link show
Date: Sun, 12 Jun 2022 09:55:04 -0600 [thread overview]
Message-ID: <6ea8a63f-dbf9-bc30-82f1-1a199ff1d1bc@gmail.com> (raw)
In-Reply-To: <20220609210516.2311379-1-jeffreyjilinux@gmail.com>
On 6/9/22 3:05 PM, Jeffrey Ji wrote:
> From: Jeffrey Ji <jeffreyji@google.com>
>
> This stat was added in commit 794c24e9921f ("net-core: rx_otherhost_dropped to core_stats")
>
> Tested: sent packet with wrong MAC address from 1
> network namespace to another, verified that counter showed "1" in
> `ip -s -s link sh` and `ip -s -s -j link sh`
>
> Signed-off-by: Jeffrey Ji <jeffreyji@google.com>
> ---
> changelog:
> v2: otherhost <- otherhost_dropped
>
> ip/ipaddress.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
...
> @@ -825,6 +834,9 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
> print_num(fp, cols[5], s->rx_over_errors);
> if (s->rx_nohandler)
> print_num(fp, cols[6], s->rx_nohandler);
> + if (s->rx_otherhost_dropped)
> + print_num(fp, cols[7],
> + s->rx_otherhost_dropped);
brought that up to 1-line and applied to iproute2-next
prev parent reply other threads:[~2022-06-12 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 21:05 [PATCH iproute2-next v2] show rx_otherehost_dropped stat in ip link show Jeffrey Ji
2022-06-09 21:07 ` Jeffrey Ji
2022-06-09 21:08 ` Jeffrey Ji
2022-06-09 21:12 ` Jeffrey Ji
2022-06-12 15:55 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea8a63f-dbf9-bc30-82f1-1a199ff1d1bc@gmail.com \
--to=dsahern@gmail.com \
--cc=brianvv@google.com \
--cc=jeffreyji@google.com \
--cc=jeffreyjilinux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).