From: Graham Gower <graham.gower@gmail.com>
To: Roger While <simrw@sim-basis.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
Date: Tue, 3 Jan 2006 22:49:33 +1030 [thread overview]
Message-ID: <6ec4247d0601030419w377fd396x@mail.gmail.com> (raw)
In-Reply-To: <6.1.1.1.2.20060103105620.02c523e0@192.168.6.12>
012345678901234567890123456789012345678901234567890123456789
On 03/01/06, Roger While <simrw@sim-basis.de> wrote:
> What makes you think this is in IRQ context ?
>
Er... yeah. I must have been off my nut when I wrote that comment.
A more apt comment should perhaps have been "dev_kfree_skb shouldn't be
used with interrupts disabled". Forgive my noobness, I'm a kernel patch virgin.
My logs were starting to fill with messages exatcly like that mentioned here:
http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840
In any event, the patch at the end of that link was never applied (it doesn't
fix the other call to dev_kfree_skb). After applying my patch, I've not had any
more messages in the logs.
Graham
next parent reply other threads:[~2006-01-03 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6.1.1.1.2.20060103105620.02c523e0@192.168.6.12>
2006-01-03 12:19 ` Graham Gower [this message]
2006-01-03 13:11 ` [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context Patrick McHardy
2006-01-03 23:03 ` Graham Gower
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec4247d0601030419w377fd396x@mail.gmail.com \
--to=graham.gower@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simrw@sim-basis.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).