Re: [PATCH v3] team: reject CAN and IEEE 802.15.4 devices in team_port_add

[Paolo Abeni <pabeni@redhat.com>]

On 10/14/26 13:49, Oliver Hartkopp wrote:
> On 14.10.26 10:37, netdev-bot+sashiko@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 1 potential
>> issue(s) to consider.
>>
>> Critical: 0 · High: 1 (1) · Medium: 0 · Low: 0
>>
>> If you believe none of the issues are legitimate, please reply to each
>> issue of Medium severity or higher and explain why the AI is wrong.
>> If any of them are legitimate and you plan to respin, please let patchwork
>> know by including "pw-bot: cr" as a separate line at the end of your reply
>> (one such reply per series is enough).
>>
>> - [High] The new denylist in team_port_add()
>>    (drivers/net/team/team_core.c:1228-1236) only rejects ARPHRD_CAN,…
>>
>> Pre-existing issues:
>> - [High] This problem wasn't introduced by this patch, but the bonding
>>    driver, which the commit message cites as the precedent being…
>>
>> -- 
>>
>> team: reject CAN and IEEE 802.15.4 devices in team_port_add
>>
>> This patch makes team_port_add() reject ports of type ARPHRD_CAN,
>> ARPHRD_IEEE802154 and ARPHRD_IEEE802154_MONITOR. Team never sets up the
>> private mid-layer data these L2 types expect, so enslaving one leads to a
>> NULL pointer dereference. The check mirrors the CAN check bonding has had
>> since commit 8ba68464e478.
>>
>> Link: https://lore.kernel.org/all/b58d98e0-8fe3-4e4e-b8a5-c1c7e647ccca@hartkopp.net/
>>
>>> diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
>>> index ca75f08e3c593..5f1708c2a3445 100644
>>> --- a/drivers/net/team/team_core.c
>>> +++ b/drivers/net/team/team_core.c
>>> @@ -1225,6 +1225,16 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
>>>           return -EINVAL;
>>>       }
>>> +    if (port_dev->type == ARPHRD_CAN ||
>>> +        port_dev->type == ARPHRD_IEEE802154 ||
>>> +        port_dev->type == ARPHRD_IEEE802154_MONITOR) {
>>
>> [Severity: High]
>> Does this list cover the whole class of devices the commit message
>> describes? ARPHRD_6LOWPAN devices still seem to get through
>> team_port_add(). Examples are lowpan0 on top of wpan0, or a Bluetooth bt0.
> 
> I'll send a v4 covering ARPHRD_6LOWPAN too.
If this message is not too late, please additionally include the
relevant stack trace in the commit message.

Thanks,

Paolo