From: Matthieu Baerts <matttbe@kernel.org>
To: Allison Henderson <achender@kernel.org>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net] selftests: rds: config: disable modules
Date: Wed, 20 May 2026 19:40:24 +1000 [thread overview]
Message-ID: <6edd89b0-68f8-4e28-ba7c-7a5df7f47c01@kernel.org> (raw)
In-Reply-To: <8a10cffb9bdde6f90f0fd7b00679755a593f2d6e.camel@kernel.org>
Hi Allison,
On 20/05/2026 14:22, Allison Henderson wrote:
> On Wed, 2026-05-20 at 11:34 +1000, Matthieu Baerts (NGI0) wrote:
>> The run.sh script explicitly checks that CONFIG_MODULES is disabled.
>>
>> By default, this config option is enabled. Explicitly disable it to be
>> able to run the RDS tests.
>>
>> Note that writing '# CONFIG_(...) is not set' is usually recommended to
>> disable an option in the .config, but it looks like selftests usually
>> set 'CONFIG_(...)=n', which looks clearer.
(...)
> The fix looks fine to me. Thanks for catching this.
Thank you for the review. Note that NIPA is now validating these tests:
https://netdev.bots.linux.dev/contest.html?test=run-sh
https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=run-sh
Note that it might be good to rename the script name, "run.sh" is a bit
too generic :)
Cheers,
Matt
prev parent reply other threads:[~2026-05-20 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 1:34 [PATCH net] selftests: rds: config: disable modules Matthieu Baerts (NGI0)
2026-05-20 4:22 ` Allison Henderson
2026-05-20 9:40 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6edd89b0-68f8-4e28-ba7c-7a5df7f47c01@kernel.org \
--to=matttbe@kernel.org \
--cc=achender@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox