From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FE2C43381 for ; Sun, 17 Feb 2019 10:06:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1222C2192C for ; Sun, 17 Feb 2019 10:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728114AbfBQKGZ (ORCPT ); Sun, 17 Feb 2019 05:06:25 -0500 Received: from mga09.intel.com ([134.134.136.24]:30678 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726638AbfBQKGZ (ORCPT ); Sun, 17 Feb 2019 05:06:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2019 02:06:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,380,1544515200"; d="scan'208";a="115602336" Received: from sneftin-mobl1.ger.corp.intel.com (HELO [10.185.23.11]) ([10.185.23.11]) by orsmga007.jf.intel.com with ESMTP; 17 Feb 2019 02:06:23 -0800 Subject: Re: [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static To: Wei Yongjun , Jeff Kirsher Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190216020442.14206-1-weiyongjun1@huawei.com> From: "Neftin, Sasha" Message-ID: <6ef2f327-8dc6-4c86-f42d-4aa7508d19f5@intel.com> Date: Sun, 17 Feb 2019 12:06:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20190216020442.14206-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/16/2019 04:04, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning: > symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static? > > Fixes: 8c5ad0dae93c ("igc: Add ethtool support") > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c > index eff37a6c0afa..544239422577 100644 > --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c > +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c > @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev, > return 0; > } > > -void igc_write_rss_indir_tbl(struct igc_adapter *adapter) > +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter) > { > struct igc_hw *hw = &adapter->hw; > u32 reg = IGC_RETA(0); > > > NACK 'igc_write_rss_indir_tbl' method declared in igc.h file. This method used in both igc_ethtool.c and igc_main.c and can't be a 'static'