From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C46142905 for ; Mon, 27 Jan 2025 18:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738001568; cv=none; b=VHW8aD7SI7vq/5UKS7l0WLK4J85bGoY0Q276OmC1kYu4xbNzXygxhFIODrwPq3A3B0r89cMScJG8VNEvIUrflnCG/ovQxJhoQPi6e+zqthusiJYkb0dFnSJCskO9SShAe2LG56ekqUQ96reI7A19hj9+umYMC8j2cZweBHAID/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738001568; c=relaxed/simple; bh=/wrFbhydSv/FGAn6GPXSiG8ZrZqE0JM4AwGjVrk9wPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uE7pp3vq0A26enySyD4GmRHfhfI8hy5Pa0yFh4OGgYP/4U6/11nnpZlC5Fp8y0nuZm1idI+TkP1JwF2A5aVx5AX4Jj9Ou4y4znQJ6FOBeFZHaq26khgtH8wRCH5Nb1wTJVInfd9YANFA6IdJnjFIjkBAtm5XDEhvttIocP2NG1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=CiqSOIP2; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="CiqSOIP2" Message-ID: <6f1126a7-b35a-4dc0-9c6e-29cfb6e7a145@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738001549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FPI7DyiaMsXtZMBlYnw4xZXHcDCDrr1uLn4/9aG94Gk=; b=CiqSOIP2zMnvHhojZE0wozYafwYRLsLp53Zk8ks9+q4BzbF384Ym7hwbVZh6aa1AUSljz6 g8JWvw5jsSuZ4sbmaTmXHuYWHUSbs0LS85yjm+tHAkCDq68PB9bMv4LJI8Eeqr+R1xvc2L j4H0pgnP4vuw6DN2VnLzxxNmPLN6kzs= Date: Tue, 28 Jan 2025 02:11:36 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net v4 2/3] net: stmmac: Limit FIFO size by hardware capability To: Kunihiko Hayashi , Alexandre Torgue , Jose Abreu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Russell King , Furong Xu <0x1207@gmail.com>, Joao Pinto , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250127013820.2941044-1-hayashi.kunihiko@socionext.com> <20250127013820.2941044-3-hayashi.kunihiko@socionext.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanteng Si In-Reply-To: <20250127013820.2941044-3-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 1/27/25 09:38, Kunihiko Hayashi 写道: > Tx/Rx FIFO size is specified by the parameter "{tx,rx}-fifo-depth" from > stmmac_platform layer. > > However, these values are constrained by upper limits determined by the > capabilities of each hardware feature. There is a risk that the upper > bits will be truncated due to the calculation, so it's appropriate to > limit them to the upper limit values and display a warning message. > > This only works if the hardware capability has the upper limit values. > > Fixes: e7877f52fd4a ("stmmac: Read tx-fifo-depth and rx-fifo-depth from the devicetree") > Signed-off-by: Kunihiko Hayashi Reviewed-by: Yanteng Si Thanks, Yanteng