Netdev List
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ido Schimmel <idosch@nvidia.com>, netdev <netdev@vger.kernel.org>
Subject: Re: VLAN aware bridge multicast and quierer problems
Date: Wed, 13 Mar 2024 18:58:44 +0200	[thread overview]
Message-ID: <6f3a60a7-db29-4a7b-afec-aa5c5fa78c93@blackwall.org> (raw)
In-Reply-To: <0f752b89-bc4b-40cf-bd4d-ac4e7d3fab2d@lunn.ch>

On 3/13/24 18:56, Andrew Lunn wrote:
>> Hi Andrew,
>> Please check again, br_multicast_rcv() which is called before
>> br_multicast_querier_exists() should set brmctx and pmctx to
>> the proper vlan contexts. If vlan igmp snooping is enabled then
>> the call to br_multicast_querier_exists() is done with the vlan's
>> contexts. I'd guess per-vlan igmp snooping is not enabled (it is not
>> enabled by default).
> 
> So i have the test running, and i see:
> 
> # bridge vlan global show
> port              vlan-id
> brtest0           1
>                      mcast_snooping 1 mcast_querier 0 mcast_igmp_version 2 mcast_
> mld_version 1 mcast_last_member_count 2 mcast_last_member_interval 100 mcast_sta
> rtup_query_count 2 mcast_startup_query_interval 3125 mcast_membership_interval 2
> 6000 mcast_querier_interval 25500 mcast_query_interval 12500 mcast_query_respons
> e_interval 1000
>                    100
>                      mcast_snooping 1 mcast_querier 0 mcast_igmp_version 2 mcast_
> mld_version 1 mcast_last_member_count 2 mcast_last_member_interval 100 mcast_sta
> rtup_query_count 2 mcast_startup_query_interval 3125 mcast_membership_interval 2
> 6000 mcast_querier_interval 25500 mcast_query_interval 12500 mcast_query_respons
> e_interval 1000
>                    200
>                      mcast_snooping 1 mcast_querier 0 mcast_igmp_version 2 mcast_
> mld_version 1 mcast_last_member_count 2 mcast_last_member_interval 100 mcast_sta
> rtup_query_count 2 mcast_startup_query_interval 3125 mcast_membership_interval 2
> 6000 mcast_querier_interval 25500 mcast_query_interval 12500 mcast_query_respons
> e_interval 1000
> 
> 
> The fact that 'mcast_snooping 1' indicates to me snooping is enabled
> by default? The test case does not change any snooping configuration.
> 
> I will send you off list the test script.
> 
>    Andrew

Oh there's a misunderstanding - this is the per-vlan control of
snooping. You have to enable the global per-vlan snooping for
these to take effect (mcast_vlan_snooping).
e.g.:
$ ip l set dev br0 type bridge vlan_filtering 1 mcast_vlan_snooping 1

You should verify in ip -d link sh dev <bridge> that mcast_vlan_snooping
is 1 (enabled), it is 0 (disabled) by default.



      reply	other threads:[~2024-03-13 16:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 15:40 VLAN aware bridge multicast and quierer problems Andrew Lunn
2024-03-13 16:03 ` Nikolay Aleksandrov
2024-03-13 16:36   ` Andrew Lunn
2024-03-13 16:46     ` Nikolay Aleksandrov
2024-03-13 16:56   ` Andrew Lunn
2024-03-13 16:58     ` Nikolay Aleksandrov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f3a60a7-db29-4a7b-afec-aa5c5fa78c93@blackwall.org \
    --to=razor@blackwall.org \
    --cc=andrew@lunn.ch \
    --cc=idosch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox