From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yonghong Song Subject: Re: [PATCH bpf-next v2 2/8] bpf: btf: fix struct/union/fwd types with kind_flag Date: Sat, 15 Dec 2018 23:12:19 +0000 Message-ID: <6f4ebb07-f553-b400-c8cd-da65e077f4d8@fb.com> References: <20181214233425.2667487-1-yhs@fb.com> <20181214233427.2667602-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Alexei Starovoitov , Kernel Team , "Martin Lau" To: Daniel Borkmann , "netdev@vger.kernel.org" Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:59180 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727558AbeLOXMn (ORCPT ); Sat, 15 Dec 2018 18:12:43 -0500 In-Reply-To: Content-Language: en-US Content-ID: <3F312C0E62F6D34A81A1841E41094ECE@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: DQoNCk9uIDEyLzE1LzE4IDI6MzcgUE0sIERhbmllbCBCb3JrbWFubiB3cm90ZToNCj4gT24gMTIv MTUvMjAxOCAxMjozNCBBTSwgWW9uZ2hvbmcgU29uZyB3cm90ZToNCj4+IFRoaXMgcGF0Y2ggZml4 ZWQgdHdvIGlzc3VlcyB3aXRoIEJURi4gT25lIGlzIHJlbGF0ZWQgdG8NCj4+IHN0cnVjdC91bmlv biBiaXRmaWVsZCBlbmNvZGluZyBhbmQgdGhlIG90aGVyIGlzIHJlbGF0ZWQgdG8NCj4+IGZvcndh cmQgdHlwZS4NCj4+DQo+PiBJc3N1ZSAjMSBhbmQgc29sdXRpb246DQo+PiA9PT09PT09PT09PT09 PT09PT09PT09DQo+Pg0KPj4gQ3VycmVudCBidGYgZW5jb2Rpbmcgb2YgYml0ZmllbGQgZm9sbG93 cyB3aGF0IHBhaG9sZSBnZW5lcmF0ZXMuDQo+PiBGb3IgZWFjaCBiaXRmaWVsZCwgcGFob2xlIHdp bGwgZHVwbGljYXRlIHRoZSB0eXBlIGNoYWluIGFuZA0KPj4gcHV0IHRoZSBiaXRmaWVsZCBzaXpl IGF0IHRoZSBmaW5hbCBpbnQgb3IgZW51bSB0eXBlLg0KPj4gU2luY2UgdGhlIEJURiBlbnVtIHR5 cGUgY2Fubm90IGVuY29kZSBiaXQgc2l6ZSwNCj4+IHBhaG9sZSB3b3JrYXJvdW5kcyB0aGUgaXNz dWUgYnkgZ2VuZXJhdGluZw0KPj4gYW4gaW50IHR5cGUgd2hlbmV2ZXIgdGhlIGVudW0gYml0IHNp emUgaXMgbm90IDMyLg0KPj4NCj4+IEZvciBleGFtcGxlLA0KPj4gICAgLWJhc2gtNC40JCBjYXQg dC5jDQo+PiAgICB0eXBlZGVmIGludCBfX19pbnQ7DQo+PiAgICBlbnVtIEEgeyBBMSwgQTIsIEEz IH07DQo+PiAgICBzdHJ1Y3QgdCB7DQo+PiAgICAgIGludCBhWzVdOw0KPj4gICAgICBfX19pbnQg Yjo0Ow0KPj4gICAgICB2b2xhdGlsZSBlbnVtIEEgYzo0Ow0KPj4gICAgfSBnOw0KPj4gICAgLWJh c2gtNC40JCBnY2MgLWMgLU8yIC1nIHQuYw0KPj4gVGhlIGN1cnJlbnQga2VybmVsIHN1cHBvcnRz IHRoZSBmb2xsb3dpbmcgQlRGIGVuY29kaW5nOg0KPj4gICAgJCBwYWhvbGUgLUpWIHQubw0KPj4g ICAgWzFdIFRZUEVERUYgX19faW50IHR5cGVfaWQ9Mg0KPj4gICAgWzJdIElOVCBpbnQgc2l6ZT00 IGJpdF9vZmZzZXQ9MCBucl9iaXRzPTMyIGVuY29kaW5nPVNJR05FRA0KPj4gICAgWzNdIEVOVU0g QSBzaXplPTQgdmxlbj0zDQo+PiAgICAgICAgICBBMSB2YWw9MA0KPj4gICAgICAgICAgQTIgdmFs PTENCj4+ICAgICAgICAgIEEzIHZhbD0yDQo+PiAgICBbNF0gU1RSVUNUIHQgc2l6ZT0yNCB2bGVu PTMNCj4+ICAgICAgICAgIGEgdHlwZV9pZD01IGJpdHNfb2Zmc2V0PTANCj4+ICAgICAgICAgIGIg dHlwZV9pZD05IGJpdHNfb2Zmc2V0PTE2MA0KPj4gICAgICAgICAgYyB0eXBlX2lkPTExIGJpdHNf b2Zmc2V0PTE2NA0KPj4gICAgWzVdIEFSUkFZIChhbm9uKSB0eXBlX2lkPTIgaW5kZXhfdHlwZV9p ZD0yIG5yX2VsZW1zPTUNCj4+ICAgIFs2XSBJTlQgc2l6ZXR5cGUgc2l6ZT04IGJpdF9vZmZzZXQ9 MCBucl9iaXRzPTY0IGVuY29kaW5nPShub25lKQ0KPj4gICAgWzddIFZPTEFUSUxFIChhbm9uKSB0 eXBlX2lkPTMNCj4+ICAgIFs4XSBJTlQgaW50IHNpemU9MSBiaXRfb2Zmc2V0PTAgbnJfYml0cz00 IGVuY29kaW5nPShub25lKQ0KPj4gICAgWzldIFRZUEVERUYgX19faW50IHR5cGVfaWQ9OA0KPj4g ICAgWzEwXSBJTlQgKGFub24pIHNpemU9MSBiaXRfb2Zmc2V0PTAgbnJfYml0cz00IGVuY29kaW5n PVNJR05FRA0KPj4gICAgWzExXSBWT0xBVElMRSAoYW5vbikgdHlwZV9pZD0xMA0KPj4NCj4+IFR3 byBpc3N1ZXMgYXJlIGluIHRoZSBhYm92ZToNCj4+ICAgIC4gYnkgY2hhbmdpbmcgZW51bSB0eXBl IHRvIGludCwgd2UgbG9zdCB0aGUgb3JpZ2luYWwNCj4+ICAgICAgdHlwZSBpbmZvcm1hdGlvbiBh bmQgdGhpcyB3aWxsIG5vdCBiZSBpZGVhbCBsYXRlcg0KPj4gICAgICB3aGVuIHdlIHRyeSB0byBj b252ZXJ0IEJURiB0byBhIGhlYWRlciBmaWxlLg0KPj4gICAgLiB0aGUgdHlwZSBkdXBsaWNhdGlv biBmb3IgYml0ZmllbGRzIHdpbGwgY2F1c2UNCj4+ICAgICAgQlRGIGJsb2F0LiBEdXBsaWNhdGVk IHR5cGVzIGNhbm5vdCBiZSBkZWR1cGxpY2F0ZWQNCj4+ICAgICAgbGF0ZXIgaWYgdGhlIGJpdGZp ZWxkIHNpemUgaXMgZGlmZmVyZW50Lg0KPj4NCj4+IFRvIGZpeCB0aGlzIGlzc3VlLCB0aGlzIHBh dGNoIGltcGxlbWVudGVkIGEgY29tcGF0aWJsZQ0KPj4gY2hhbmdlIGZvciBCVEYgc3RydWN0IHR5 cGUgZW5jb2Rpbmc6DQo+PiAgICAuIHRoZSBiaXQgMzEgb2Ygc3RydWN0X3R5cGUtPmluZm8sIHBy ZXZpb3VzbHkgcmVzZXJ2ZWQsDQo+PiAgICAgIG5vdyBpcyB1c2VkIHRvIGluZGljYXRlIHdoZXRo ZXIgYml0ZmllbGRfc2l6ZSBpcw0KPj4gICAgICBlbmNvZGVkIGluIGJ0Zl9tZW1iZXIgb3Igbm90 Lg0KPj4gICAgLiBpZiBiaXQgMzEgb2Ygc3RydWN0X3R5cGUtPmluZm8gaXMgc2V0LA0KPj4gICAg ICBidGZfbWVtYmVyLT5vZmZzZXQgd2lsbCBlbmNvZGUgbGlrZToNCj4+ICAgICAgICBiaXQgMCAt IDIzOiBiaXQgb2Zmc2V0DQo+PiAgICAgICAgYml0IDI0IC0gMzE6IGJpdGZpZWxkIHNpemUNCj4+ ICAgICAgaWYgYml0IDMxIGlzIG5vdCBzZXQsIHRoZSBvbGQgYmVoYXZpb3IgaXMgcHJlc2VydmVk Og0KPj4gICAgICAgIGJpdCAwIC0gMzE6IGJpdCBvZmZzZXQNCj4+DQo+PiBTbyBpZiB0aGUgc3Ry dWN0IGNvbnRhaW5zIGEgYml0IGZpZWxkLCB0aGUgbWF4aW11bSBiaXQgb2Zmc2V0DQo+PiB3aWxs IGJlIHJlZHVjZWQgdG8gKDJeMjQgLSAxKSBpbnN0ZWFkIG9mIE1BWF9VSU5ULiBUaGUgbWF4aW11 bQ0KPj4gYml0ZmllbGQgc2l6ZSB3aWxsIGJlIDI1NiB3aGljaCBpcyBlbm91Z2ggZm9yIHRvZGF5 IGFzIG1heGltdW0NCj4+IGJpdGZpZWxkIGluIGNvbXBpbGVyIGNhbiBiZSAxMjggd2hlcmUgaW50 MTI4IHR5cGUgaXMgc3VwcG9ydGVkLg0KPiANCj4gTG9va3MgZ29vZCBpbiBnZW5lcmFsLCBqdXN0 IHNtYWxsIG5pdCBiZWxvdy4NCj4gDQo+PiBUaGlzIGtlcm5lbCBwYXRjaCBpbnRlbmRzIHRvIHN1 cHBvcnQgdGhlIG5ldyBCVEYgZW5jb2Rpbmc6DQo+PiAgICAkIHBhaG9sZSAtSlYgdC5vDQo+PiAg ICBbMV0gVFlQRURFRiBfX19pbnQgdHlwZV9pZD0yDQo+PiAgICBbMl0gSU5UIGludCBzaXplPTQg Yml0X29mZnNldD0wIG5yX2JpdHM9MzIgZW5jb2Rpbmc9U0lHTkVEDQo+PiAgICBbM10gRU5VTSBB IHNpemU9NCB2bGVuPTMNCj4+ICAgICAgICAgIEExIHZhbD0wDQo+PiAgICAgICAgICBBMiB2YWw9 MQ0KPj4gICAgICAgICAgQTMgdmFsPTINCj4+ICAgIFs0XSBTVFJVQ1QgdCBraW5kX2ZsYWc9MSBz aXplPTI0IHZsZW49Mw0KPj4gICAgICAgICAgYSB0eXBlX2lkPTUgYml0ZmllbGRfc2l6ZT0wIGJp dHNfb2Zmc2V0PTANCj4+ICAgICAgICAgIGIgdHlwZV9pZD0xIGJpdGZpZWxkX3NpemU9NCBiaXRz X29mZnNldD0xNjANCj4+ICAgICAgICAgIGMgdHlwZV9pZD03IGJpdGZpZWxkX3NpemU9NCBiaXRz X29mZnNldD0xNjQNCj4+ICAgIFs1XSBBUlJBWSAoYW5vbikgdHlwZV9pZD0yIGluZGV4X3R5cGVf aWQ9MiBucl9lbGVtcz01DQo+PiAgICBbNl0gSU5UIHNpemV0eXBlIHNpemU9OCBiaXRfb2Zmc2V0 PTAgbnJfYml0cz02NCBlbmNvZGluZz0obm9uZSkNCj4+ICAgIFs3XSBWT0xBVElMRSAoYW5vbikg dHlwZV9pZD0zDQo+IFsuLi5dDQo+PiArc3RhdGljIGludCBidGZfaW50X2NoZWNrX2tmbGFnX21l bWJlcihzdHJ1Y3QgYnRmX3ZlcmlmaWVyX2VudiAqZW52LA0KPj4gKwkJCQkgICAgICBjb25zdCBz dHJ1Y3QgYnRmX3R5cGUgKnN0cnVjdF90eXBlLA0KPj4gKwkJCQkgICAgICBjb25zdCBzdHJ1Y3Qg YnRmX21lbWJlciAqbWVtYmVyLA0KPj4gKwkJCQkgICAgICBjb25zdCBzdHJ1Y3QgYnRmX3R5cGUg Km1lbWJlcl90eXBlKQ0KPj4gK3sNCj4+ICsJdTMyIHN0cnVjdF9iaXRzX29mZiwgbnJfYml0cywg bnJfaW50X2RhdGFfYml0cywgYnl0ZXNfb2Zmc2V0Ow0KPj4gKwl1MzIgaW50X2RhdGEgPSBidGZf dHlwZV9pbnQobWVtYmVyX3R5cGUpOw0KPj4gKwl1MzIgc3RydWN0X3NpemUgPSBzdHJ1Y3RfdHlw ZS0+c2l6ZTsNCj4+ICsJdTMyIG5yX2NvcHlfYml0czsNCj4+ICsNCj4+ICsJLyogYSByZWd1bGFy IGludCB0eXBlIGlzIHJlcXVpcmVkIGZvciB0aGUga2ZsYWcgaW50IG1lbWJlciAqLw0KPj4gKwlp ZiAoIWJ0Zl90eXBlX2ludF9pc19yZWd1bGFyKG1lbWJlcl90eXBlKSkgew0KPj4gKwkJYnRmX3Zl cmlmaWVyX2xvZ19tZW1iZXIoZW52LCBzdHJ1Y3RfdHlwZSwgbWVtYmVyLA0KPj4gKwkJCQkJIklu dmFsaWQgbWVtYmVyIGJhc2UgdHlwZSIpOw0KPj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+PiArCX0N Cj4+ICsNCj4+ICsJLyogY2hlY2sgc2FuaXR5IG9mIGJpdGZpZWxkIHNpemUgKi8NCj4+ICsJbnJf Yml0cyA9IEJURl9NRU1CRVJfQklURklFTERfU0laRShtZW1iZXItPm9mZnNldCk7DQo+PiArCXN0 cnVjdF9iaXRzX29mZiA9IEJURl9NRU1CRVJfQklUX09GRlNFVChtZW1iZXItPm9mZnNldCk7DQo+ PiArCW5yX2ludF9kYXRhX2JpdHMgPSBCVEZfSU5UX0JJVFMoaW50X2RhdGEpOw0KPj4gKwlpZiAo IW5yX2JpdHMpIHsNCj4+ICsJCS8qIE5vdCBhIGJpdGZpZWxkIG1lbWJlciwgbWVtYmVyIG9mZnNl dCBtdXN0IGJlIGF0IGJ5dGUNCj4+ICsJCSAqIGJvdW5kYXJ5Lg0KPj4gKwkJICovDQo+PiArCQlp ZiAoQklUU19QRVJfQllURV9NQVNLRUQoc3RydWN0X2JpdHNfb2ZmKSkgew0KPj4gKwkJCWJ0Zl92 ZXJpZmllcl9sb2dfbWVtYmVyKGVudiwgc3RydWN0X3R5cGUsIG1lbWJlciwNCj4+ICsJCQkJCQki SW52YWxpZCBtZW1iZXIgb2Zmc2V0Iik7DQo+PiArCQkJcmV0dXJuIC1FSU5WQUw7DQo+PiArCQl9 DQo+PiArDQo+PiArCQlucl9iaXRzID0gbnJfaW50X2RhdGFfYml0czsNCj4+ICsJfSBlbHNlIGlm IChucl9iaXRzID4gbnJfaW50X2RhdGFfYml0cykgew0KPiANCj4gU2hvdWxkIHRoZSB0ZXN0IGhl cmUgbm90IGluY2x1ZGUgdGhlIGJpdCBvZmZzZXQgYXMgd2VsbCBha2EgbnJfY29weV9iaXRzPw0K PiBUaHVzIHRlc3Qgd291bGQgYmUgZS5nLiAobnJfY29weV9iaXRzID4gbnJfaW50X2RhdGFfYml0 cyB8fCBucl9jb3B5X2JpdHMgPg0KPiBCSVRTX1BFUl9VNjQpIC4uLg0KDQpUaGUgdGVzdCBoZXJl IGlzIHN0cmljdGx5IGNoZWNraW5nIHdoZXRoZXIgdGhlIGJpdGZpZWxkIHNpemUgaXMgY292ZXJl ZCANCmJ5IHVuZGVybHlpbmcgaW50IHR5cGUuDQogICAgc3RydWN0IHQgew0KICAgICAgIGludCBh OjE7DQogICAgICAgY2hhciBiOjg7DQogICAgICAgLi4uDQogICAgfQ0KSW4gdGhpcyBjYXNlLCBm b3IgbWVtYmVyICJiIiwgYml0c2l6ZSA9IDgsIG5yX2NvcHlfYml0cyA9IDksIA0KbnJfaW50X2Rh dGFfYml0cyA9IDguIG5yX2NvcHlfYml0cyA+IG5yX2ludF9kYXRhX2JpdHMsIGJ1dCBpdCBpcyBs ZWdhbC4NCg0KDQo+IFdydCB0byBmdXR1cmUgMjU2IGJpdCBzdXBwb3J0LCBkb2Vzbid0IFVBUEkg b24gQlRGX0lOVF9CSVRTKCkgb25seSBzdXBwb3J0DQo+IHVwIHRvIG1heCAyNTUgYml0cz8NCg0K VGhpcyBpcyBhIGdvb2QgcXVlc3Rpb24uIEJURl9JTlRfQklUUygpIGNhbiBiZSBleHRlbmRlZCB0 byBtYXhpbXVtIA0KMHhmZmZmLiBUaGVyZSBhcmUgYml0cyBhdmFpbGFibGUgdGhlcmUuDQoNCldo ZW4gdGhlIGtpbmRfZmxhZyBpcyBzZXQsIHRoZSBiaXRmaWVsZCBzaXplIGNhbiByYW5nZSBmcm9t IDEgdG8gMjU1LA0KdGhlIHNhbWUgYXMgdG9kYXkgQlRGX0lOVF9CSVRTIHJhbmdlLiBJZiB1c2Vy IHdyaXRlcw0Kc3RydWN0IHQgew0KICAgIC4uLg0KICAgIGludDI1NiBtOjI1NjsNCiAgICAuLi4N Cn07DQpUaGUgYml0ZmllbGQgc2l6ZSBpbmZvcm1hdGlvbiB3aWxsIG5vdCBnZXQgZW5jb2RlZCBh bmQgdGhlIG1lbWJlciAibSIgDQp3aWxsIGp1c3QgcmVmZXIgdG8gYSBiYXNlIHR5cGUgaW50MjU2 LCB0aGUgc2FtZSBhcw0Kc3RydWN0IHQgew0KICAgIC4uLg0KICAgIGludDI1NiBtOw0KICAgIC4u Lg0KfTsNCg0KRGlkIHlvdSBhbnkgcHJvYmxlbSB3aXRoIHRoaXM/DQoNCj4gDQo+PiArCQlidGZf dmVyaWZpZXJfbG9nX21lbWJlcihlbnYsIHN0cnVjdF90eXBlLCBtZW1iZXIsDQo+PiArCQkJCQki SW52YWxpZCBtZW1iZXIgYml0ZmllbGRfc2l6ZSIpOw0KPj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ PiArCX0NCj4+ICsNCj4+ICsJYnl0ZXNfb2Zmc2V0ID0gQklUU19ST1VORERPV05fQllURVMoc3Ry dWN0X2JpdHNfb2ZmKTsNCj4+ICsJbnJfY29weV9iaXRzID0gbnJfYml0cyArIEJJVFNfUEVSX0JZ VEVfTUFTS0VEKHN0cnVjdF9iaXRzX29mZik7DQo+PiArCWlmIChucl9jb3B5X2JpdHMgPiBCSVRT X1BFUl9VNjQpIHsNCj4+ICsJCWJ0Zl92ZXJpZmllcl9sb2dfbWVtYmVyKGVudiwgc3RydWN0X3R5 cGUsIG1lbWJlciwNCj4+ICsJCQkJCSJucl9jb3B5X2JpdHMgZXhjZWVkcyA2NCIpOw0KPj4gKwkJ cmV0dXJuIC1FSU5WQUw7DQo+PiArCX0NCj4+ICsNCj4+ICsJaWYgKHN0cnVjdF9zaXplIDwgYnl0 ZXNfb2Zmc2V0IHx8DQo+PiArCSAgICBzdHJ1Y3Rfc2l6ZSAtIGJ5dGVzX29mZnNldCA8IEJJVFNf Uk9VTkRVUF9CWVRFUyhucl9jb3B5X2JpdHMpKSB7DQo+PiArCQlidGZfdmVyaWZpZXJfbG9nX21l bWJlcihlbnYsIHN0cnVjdF90eXBlLCBtZW1iZXIsDQo+PiArCQkJCQkiTWVtYmVyIGV4Y2VlZHMg c3RydWN0X3NpemUiKTsNCj4+ICsJCXJldHVybiAtRUlOVkFMOw0KPj4gKwl9DQo+PiArDQo+PiAr CXJldHVybiAwOw0KPj4gK30NCg==