From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [iproute PATCH] link_gre6: Detect invalid encaplimit values Date: Thu, 30 Nov 2017 14:02:50 +0100 Message-ID: <6f8269be-363c-7f57-31cb-72f58495c68a@6wind.com> References: <20171128154958.18403-1-phil@nwl.cc> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org To: Phil Sutter , Stephen Hemminger Return-path: Received: from mail-wr0-f174.google.com ([209.85.128.174]:41949 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbdK3NCy (ORCPT ); Thu, 30 Nov 2017 08:02:54 -0500 Received: by mail-wr0-f174.google.com with SMTP id z18so6522202wrb.8 for ; Thu, 30 Nov 2017 05:02:53 -0800 (PST) In-Reply-To: <20171128154958.18403-1-phil@nwl.cc> Content-Language: fr Sender: netdev-owner@vger.kernel.org List-ID: Le 28/11/2017 à 16:49, Phil Sutter a écrit : > Looks like a typo: get_u8() returns 0 on success and -1 on error, so the > error checking here was ineffective. > > Fixes: a11b7b71a6eba ("link_gre6: really support encaplimit option") > Signed-off-by: Phil Sutter Good catch! Acked-by: Nicolas Dichtel