From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
OFED mailing list <linux-rdma@vger.kernel.org>,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
Knut Omang <knut.omang@oracle.com>
Subject: Re: [PATCH net] rds: Fix incorrect statistics counting
Date: Wed, 6 Sep 2017 09:21:01 -0700 [thread overview]
Message-ID: <6fb62a09-13b4-0cec-2864-40afdfc51d25@oracle.com> (raw)
In-Reply-To: <715EA84D-6ACA-45DE-9EA2-6122E11545E8@oracle.com>
On 9/6/2017 9:12 AM, Håkon Bugge wrote:
>
[...]
>
> Hi Santosh,
>
>
> Yes, I agree with accuracy of s_send_lock_queue_raced. But the main point is that the existing code counts some partial share of when it is _not_ raced.
>
> So, in the critical path, my patch adds one test_bit(), which hits the local CPU cache, if not raced. If raced, some other thread is in control, so I would not think the added cycles would make any big difference.
>
Cycles added for no good reason is the point.
> I can send a v2 where the race tightening is removed if you like.
>
Yes please.
Regards,
Santosh
prev parent reply other threads:[~2017-09-06 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 15:29 [PATCH net] rds: Fix incorrect statistics counting Håkon Bugge
[not found] ` <20170906152950.17766-1-Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-06 15:58 ` Santosh Shilimkar
2017-09-06 16:12 ` Håkon Bugge
2017-09-06 16:21 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb62a09-13b4-0cec-2864-40afdfc51d25@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=haakon.bugge@oracle.com \
--cc=knut.omang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox