netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
	cphealy@gmail.com, davem@davemloft.net,
	nikita.yoush@cogentembedded.com
Subject: Re: [PATCH net-next v2 0/7] net: Extend availability of PHY statistics
Date: Tue, 24 Apr 2018 17:35:09 -0700	[thread overview]
Message-ID: <6fbe8b7c-8e8a-d0d7-0df3-9163b9b5284e@gmail.com> (raw)
In-Reply-To: <20180425002748.27330-1-f.fainelli@gmail.com>

On 04/24/2018 05:27 PM, Florian Fainelli wrote:
> Hi all,
> 
> This patch series adds support for retrieving PHY statistics with DSA switches
> when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC).
> To get there a number of things are done:
> 
> - first we move the code dealing with PHY statistics outside of net/core/ethtool.c
>   and create helper functions since the same code will be reused
> - then we allow network device drivers to provide an ethtool_get_phy_stats callback
>   when the standard PHY library helpers are not suitable
> - we update the DSA functions dealing with ethtool operations to get passed a
>   stringset instead of assuming ETH_SS_STATS like they currently do
> - then we provide a set of standard helpers within DSA as a framework and add
>   the plumbing to allow retrieving the PHY statistics of the CPU port(s)
> - finally plug support for retrieving such PHY statistics with the b53 driver
> 
> Changes in v2:
> 
> - got actual testing when the DSA master network device has a PHY that
>   already provides statistics (thanks Nikita!)
> 
> - fixed the kbuild error reported when CONFIG_PHYLIB=n
> 
> - removed the checking of ops which is redundant and not needed

David, sorry looks like there will be a v3, the last patch introduces a
possible problem with bcm_sf2 which uses b53_common as a library, will
respin later.
-- 
Florian

  parent reply	other threads:[~2018-04-25  0:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  0:27 [PATCH net-next v2 0/7] net: Extend availability of PHY statistics Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 1/7] net: Move PHY statistics code into PHY library helpers Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 2/7] net: Allow network devices to have PHY statistics Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 3/7] net: dsa: Do not check for ethtool_ops validity Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 4/7] net: dsa: Pass stringset to ethtool operations Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 5/7] net: dsa: Add helper function to obtain PHY device of a given port Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 6/7] net: dsa: Allow providing PHY statistics from CPU port Florian Fainelli
2018-04-25  0:27 ` [PATCH net-next v2 7/7] net: dsa: b53: Add support for reading PHY statistics Florian Fainelli
2018-04-25  0:35 ` Florian Fainelli [this message]
2018-04-25  2:13   ` [PATCH net-next v2 0/7] net: Extend availability of " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fbe8b7c-8e8a-d0d7-0df3-9163b9b5284e@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=cphealy@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).