From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v2 0/7] net: Extend availability of PHY statistics Date: Tue, 24 Apr 2018 17:35:09 -0700 Message-ID: <6fbe8b7c-8e8a-d0d7-0df3-9163b9b5284e@gmail.com> References: <20180425002748.27330-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, cphealy@gmail.com, davem@davemloft.net, nikita.yoush@cogentembedded.com To: netdev@vger.kernel.org Return-path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:40602 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbeDYAfT (ORCPT ); Tue, 24 Apr 2018 20:35:19 -0400 Received: by mail-wm0-f50.google.com with SMTP id j5so3722581wme.5 for ; Tue, 24 Apr 2018 17:35:18 -0700 (PDT) In-Reply-To: <20180425002748.27330-1-f.fainelli@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/24/2018 05:27 PM, Florian Fainelli wrote: > Hi all, > > This patch series adds support for retrieving PHY statistics with DSA switches > when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). > To get there a number of things are done: > > - first we move the code dealing with PHY statistics outside of net/core/ethtool.c > and create helper functions since the same code will be reused > - then we allow network device drivers to provide an ethtool_get_phy_stats callback > when the standard PHY library helpers are not suitable > - we update the DSA functions dealing with ethtool operations to get passed a > stringset instead of assuming ETH_SS_STATS like they currently do > - then we provide a set of standard helpers within DSA as a framework and add > the plumbing to allow retrieving the PHY statistics of the CPU port(s) > - finally plug support for retrieving such PHY statistics with the b53 driver > > Changes in v2: > > - got actual testing when the DSA master network device has a PHY that > already provides statistics (thanks Nikita!) > > - fixed the kbuild error reported when CONFIG_PHYLIB=n > > - removed the checking of ops which is redundant and not needed David, sorry looks like there will be a v3, the last patch introduces a possible problem with bcm_sf2 which uses b53_common as a library, will respin later. -- Florian