From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] ptp: fix missing break in switch Date: Wed, 18 Jul 2018 17:39:27 -0500 Message-ID: <6fdb4c2b-8d64-a436-a4ad-68f75d60eac6@embeddedor.com> References: <20180718011733.GA27872@embeddedor.com> <20180719.072608.944784986385146557.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: stefan.sorensen@spectralink.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180719.072608.944784986385146557.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/18/2018 05:26 PM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Tue, 17 Jul 2018 20:17:33 -0500 > >> It seems that a *break* is missing in order to avoid falling through >> to the default case. Otherwise, checking *chan* makes no sense. >> >> Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function") >> Signed-off-by: Gustavo A. R. Silva > > Applied and queued up for -stable, thank you. > Great. Glad to help. :) Thanks -- Gustavo