Re: [PATCH v2 net-next 5/9] psp: add unprivileged version of psp_device_get_locked

[Daniel Zahka <daniel.zahka@gmail.com>]

On 3/3/26 7:00 PM, Wei Wang wrote:
> Add a place holder function called psp_device_get_locked_unpriv() which
> will be used for commands that are unprivileged and are used for
> exisiting commands like dev-dump, dev-get, rx-assoc, tx-assoc.
> Commands including dev-add/delete/change-ntf, key-rotate would keep
> using the privileged version.

It looks to me like get-stats is a command that is still using the 
privileged version. Is that intentional?
> @@ -72,7 +73,20 @@ int psp_device_get_locked(const struct genl_split_ops *ops,
>   		return -EINVAL;
>   
>   	info->user_ptr[0] = psp_device_get_and_lock(genl_info_net(info),
> -						    info->attrs[PSP_A_DEV_ID]);
> +						    info->attrs[PSP_A_DEV_ID],
> +						    false);
> +	return PTR_ERR_OR_ZERO(info->user_ptr[0]);
> +}
> +
> +int psp_device_get_locked_unpriv(const struct genl_split_ops *ops,
> +				 struct sk_buff *skb, struct genl_info *info)
> +{
> +	if (GENL_REQ_ATTR_CHECK(info, PSP_A_DEV_ID))
> +		return -EINVAL;
> +
> +	info->user_ptr[0] = psp_device_get_and_lock(genl_info_net(info),
> +						    info->attrs[PSP_A_DEV_ID],
> +						    true);
>   	return PTR_ERR_OR_ZERO(info->user_ptr[0]);
>   }

nit: psp_device_get_locked() and psp_device_get_locked_unpriv() are 
entirely identical modulo true/false. You could probably have something 
like __psp_device_get_locked() with the common code.