From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB41C43381 for ; Wed, 27 Mar 2019 14:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 824802075E for ; Wed, 27 Mar 2019 14:18:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jpPOsGbL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728349AbfC0OSC (ORCPT ); Wed, 27 Mar 2019 10:18:02 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39117 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728213AbfC0OSC (ORCPT ); Wed, 27 Mar 2019 10:18:02 -0400 Received: by mail-pg1-f193.google.com with SMTP id k3so6309295pga.6 for ; Wed, 27 Mar 2019 07:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gJfWttlmOTTcE+xiwq5xrvuCWtteogS0eHXDPo7j5Eg=; b=jpPOsGbLTL/SE17BrRoRf/eDzgg4DJlWX9WeWV+/wF8oGZ4lCnTJG1JQIPusEtaEjE g4rDgZCvd2BFfMM+mNQN67G1Y/vyxfx84UXuhgIcvPio5k98oPno89xdaRGYArwzZ0EQ 0sr1DsHuwUBoXxF9D9a0Pq9W1J3cWQhy42e/iSzME0ns2Mkq6781OaMc9SOe8cpxBpKj PbIgisXDtvJGkPmRDhoWhOSb8ZW5SMOrievhgzIg/RIVdZaeD7fAU0tDsg2o/Xn0TkDl 1TlgmCIcQPcbaVlRZC7CXOWV8kJNABu3sY8QfQYm/91+0vflVrcZVILgMqJiUVTqfCgU DdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gJfWttlmOTTcE+xiwq5xrvuCWtteogS0eHXDPo7j5Eg=; b=fI41O7nOj4vQkl7YUe7D6RbXhnmGk88V4isII0+GrHzBZ1oPhPvxCVDnnKx+KCJWW8 6FZ8o0OC4QLy2rYICRej+nF17x8uKzK/5UuckdmiR7oIr5Hn14AB+aPETjvmBFjVAule l5KERqoj/VotGFudx9509Aj2zy/4wSgkjm0lvzfQ2Y/ORfseXoTDXnm608IGI4ltt23w REZc/Sqy1pgmLcQPJ95fNikVPnigm5tzyLfgddmtZLrlQyPUNZB0lecsw9L06Nc8cqMX 3Zgnp+f8GbPITdL+Mf7KRGnQxf+Btf3gTFLcUrHEDsVTkYsoNGAhggzu+mvePaFyAD4m ClsQ== X-Gm-Message-State: APjAAAWmH8lN7G0+AF1CXszCYCSLzWJjK3YqL5al476Lg0m6tThhztfu QWrNbQtZwBnkGVHFS8zpSWHXxbjW X-Google-Smtp-Source: APXvYqzefR0Zy+WkiVER2H4lxQzH+OjgY6j0ZPcKdT4ALcpYvmMqo+i4jfrQiB+ZxsgRIhnKtho81A== X-Received: by 2002:a63:4b0a:: with SMTP id y10mr34424544pga.66.1553696281825; Wed, 27 Mar 2019 07:18:01 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:c1b3:1093:c763:b27f? ([2601:282:800:fd80:c1b3:1093:c763:b27f]) by smtp.googlemail.com with ESMTPSA id j20sm40855634pfi.27.2019.03.27.07.18.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 07:18:00 -0700 (PDT) Subject: Re: [PATCH net-next 06/13] ipv6: Create cleanup helper for fib6_nh To: Ido Schimmel , David Ahern Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed References: <20190327032942.20473-1-dsahern@kernel.org> <20190327032942.20473-7-dsahern@kernel.org> <20190327083851.GA15127@splinter> From: David Ahern Message-ID: <7023167f-b20b-794b-477c-391c2abff2d8@gmail.com> Date: Wed, 27 Mar 2019 08:17:59 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190327083851.GA15127@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/27/19 2:38 AM, Ido Schimmel wrote: > Why did you flip the order? > > lwtstate_put() > dev_put() > > is symmetric with fib6_nh_init() no real reason. Will reverse them