From: Jay Vosburgh <fubar@us.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mike Snitzer <snitzer@gmail.com>,
netdev@vger.kernel.org, andy@greyhouse.net
Subject: Re: [PATCH 1/6] Convert bonding timers to workqueues
Date: Mon, 22 Oct 2007 11:57:17 -0700 [thread overview]
Message-ID: <7038.1193079437@death> (raw)
In-Reply-To: <471CED48.207@garzik.org>
Jeff Garzik <jeff@garzik.org> wrote:
[...]
>I wasn't aware this brand-new code is a bug fix?
>
>Normally brand new code needs to be posted and reviewed and committed to a
>tree -before- the merge window opens.
I had thought this was going in ok, as you'd attempted to apply
it after the IPoIB stuff a week or so ago, but it needed to be rebased
and you'd had concerns about bisect.
In any event, I'd argue it's changes to fix locking bugs
(various "sleep with lock held" and ASSERT_RTNLs, e.g., bug 7974 on
bugzilla.kernel.org); this isn't a feature add or a refactor just for
efficiency.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2007-10-22 18:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 4:14 [PATCH 0/6] bonding workqueue and lock rework Jay Vosburgh
2007-10-11 4:14 ` [PATCH 1/6] Convert bonding timers to workqueues Jay Vosburgh
2007-10-11 4:14 ` [PATCH 2/6] Convert balance-rr transmit to new locking Jay Vosburgh
2007-10-11 4:14 ` [PATCH 3/6] Convert miimon " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 4/6] Convert locks to _bh, rework alb locking for " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 5/6] Convert more locks to _bh, acquire rtnl, " Jay Vosburgh
2007-10-11 4:14 ` [PATCH 6/6] Acquire correct locks in alb for promisc change Jay Vosburgh
2007-10-15 18:41 ` [PATCH 1/6] Convert bonding timers to workqueues Jeff Garzik
2007-10-15 19:08 ` Jay Vosburgh
2007-10-22 14:55 ` Mike Snitzer
2007-10-22 18:34 ` Jeff Garzik
2007-10-22 18:57 ` Jay Vosburgh [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 0:37 [PATCH 0/6] bonding workqueue and lock rework Jay Vosburgh
2007-10-18 0:37 ` [PATCH 1/6] Convert bonding timers to workqueues Jay Vosburgh
2007-10-24 0:42 ` Jeff Garzik
2007-10-24 1:00 ` Jay Vosburgh
2007-10-24 1:13 ` Andy Gospodarek
2007-10-24 1:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7038.1193079437@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=snitzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).