Re: [PATCHv3 net-next 04/10] docs: bridge: Add kAPI/uAPI fields

[Florian Fainelli <f.fainelli@gmail.com>]

On 11/28/2023 12:49 AM, Hangbin Liu wrote:
> Add kAPI/uAPI field for bridge doc. Update struct net_bridge_vlan
> comments to fix doc build warning.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>   Documentation/networking/bridge.rst | 26 ++++++++++++++++++++++++++
>   net/bridge/br_private.h             |  2 ++
>   2 files changed, 28 insertions(+)
> 
> diff --git a/Documentation/networking/bridge.rst b/Documentation/networking/bridge.rst
> index de112e92a305..5d6d3c0c15c1 100644
> --- a/Documentation/networking/bridge.rst
> +++ b/Documentation/networking/bridge.rst
> @@ -12,6 +12,32 @@ independent way. Packets are forwarded based on Layer 2 destination Ethernet
>   address, rather than IP address (like a router). Since forwarding is done
>   at Layer 2, all Layer 3 protocols can pass through a bridge transparently.
>   
> +Bridge kAPI
> +===========
> +
> +Here are some core structures of bridge code.
> +
> +.. kernel-doc:: net/bridge/br_private.h
> +   :identifiers: net_bridge_vlan
> +
> +Bridge uAPI
> +===========
> +
> +Modern Linux bridge uAPI is accessed via Netlink interface. You can find
> +below files where the bridge and bridge port netlink attributes are defined.

You dropped the sysfs documentation upon Nikolay's request which is 
fine, maybe a note here that sysfs is deprecated and only provided for 
backward compatibility.

Looks good otherwise:

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian