From: Paolo Abeni <pabeni@redhat.com>
To: kernel test robot <oliver.sang@intel.com>,
Brett A C Sheffield <bacs@librecast.net>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, netdev@vger.kernel.org,
regressions@lists.linux.dev, stable@vger.kernel.org,
davem@davemloft.net, dsahern@kernel.org, oscmaes92@gmail.com,
kuba@kernel.org
Subject: Re: [REGRESSION][BISECTED][PATCH] net: ipv4: fix regression in broadcast routes
Date: Thu, 28 Aug 2025 12:35:17 +0200 [thread overview]
Message-ID: <7090d5ae-c598-4db5-a051-b31720a27746@redhat.com> (raw)
In-Reply-To: <202508281637.f1c00f73-lkp@intel.com>
On 8/28/25 10:17 AM, kernel test robot wrote:
> commit: a1b445e1dcd6ee9682d77347faf3545b53354d71 ("[REGRESSION][BISECTED][PATCH] net: ipv4: fix regression in broadcast routes")
> url: https://github.com/intel-lab-lkp/linux/commits/Brett-A-C-Sheffield/net-ipv4-fix-regression-in-broadcast-routes/20250825-181407
> patch link: https://lore.kernel.org/all/20250822165231.4353-4-bacs@librecast.net/
> patch subject: [REGRESSION][BISECTED][PATCH] net: ipv4: fix regression in broadcast routes
>
> in testcase: trinity
> version: trinity-x86_64-ba2360ed-1_20241228
> with following parameters:
>
> runtime: 300s
> group: group-04
> nr_groups: 5
>
>
>
> config: x86_64-randconfig-104-20250826
> compiler: clang-20
> test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G
>
> (please refer to attached dmesg/kmsg for entire log/backtrace)
Since I just merged v3 of the mentioned patch and I'm wrapping the PR
for Linus, the above scared me more than a bit.
AFAICS the issue reported here is the unconditional 'fi' dereference
spotted and fixed during code review, so no real problem after all.
/P
next prev parent reply other threads:[~2025-08-28 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 16:50 [REGRESSION][BISECTED][PATCH] net: ipv4: fix regression in broadcast routes Brett A C Sheffield
2025-08-23 1:32 ` Jakub Kicinski
2025-08-23 12:13 ` [PATCH v2 1/2] selftests: net: add test for broadcast destination Brett A C Sheffield
2025-08-23 12:13 ` [PATCH v2 2/2] net: ipv4: fix regression in broadcast routes Brett A C Sheffield
2025-08-23 12:24 ` [REGRESSION][BISECTED][PATCH] " Brett Sheffield
2025-08-25 6:02 ` Oscar Maes
2025-08-25 6:09 ` [PATCH net 1/2] net: ipv4: fix regression in local-broadcast routes Oscar Maes
2025-08-25 6:09 ` [PATCH net 2/2] selftests: net: add test for destination in broadcast packets Oscar Maes
2025-08-25 7:03 ` Brett A C Sheffield
2025-08-25 22:56 ` [PATCH net 1/2] net: ipv4: fix regression in local-broadcast routes Jakub Kicinski
2025-08-26 12:11 ` Oscar Maes
2025-08-26 12:17 ` [PATCH net v2 " Oscar Maes
2025-08-26 12:17 ` [PATCH net v2 2/2] selftests: net: add test for destination in broadcast packets Oscar Maes
2025-08-27 1:29 ` Jakub Kicinski
2025-08-28 8:17 ` [REGRESSION][BISECTED][PATCH] net: ipv4: fix regression in broadcast routes kernel test robot
2025-08-28 10:35 ` Paolo Abeni [this message]
2025-08-28 10:46 ` Brett A C Sheffield
2025-08-29 2:08 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7090d5ae-c598-4db5-a051-b31720a27746@redhat.com \
--to=pabeni@redhat.com \
--cc=bacs@librecast.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=oscmaes92@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).