From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:46954 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbeCORwl (ORCPT ); Thu, 15 Mar 2018 13:52:41 -0400 Subject: Re: [PATCH net-next] rds: tcp: must use spin_lock_irq* and not spin_lock_bh with rds_tcp_conn_lock To: Sowmini Varadhan , netdev@vger.kernel.org Cc: davem@davemloft.net References: <1521111266-148947-1-git-send-email-sowmini.varadhan@oracle.com> From: Santosh Shilimkar Message-ID: <712db860-015c-a266-664b-e12cb3fbf315@oracle.com> Date: Thu, 15 Mar 2018 10:52:34 -0700 MIME-Version: 1.0 In-Reply-To: <1521111266-148947-1-git-send-email-sowmini.varadhan@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/15/2018 3:54 AM, Sowmini Varadhan wrote: > rds_tcp_connection allocation/free management has the potential to be > called from __rds_conn_create after IRQs have been disabled, so > spin_[un]lock_bh cannot be used with rds_tcp_conn_lock. > > Bottom-halves that need to synchronize for critical sections protected > by rds_tcp_conn_lock should instead use rds_destroy_pending() correctly. > > Reported-by: syzbot+c68e51bb5e699d3f8d91@syzkaller.appspotmail.com > Fixes: ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize > netns/module teardown and rds connection/workq management") > Signed-off-by: Sowmini Varadhan > --- Thanks Sowmini for the WARN_ON() discussion off-list. Acked-by: Santosh Shilimkar